darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding @nested_transactional for transactions that require more than one

Browse Source 
db update/insert.

Using a savepoint for the multiple transactions allows us to rollback if
there is an error when executing the second db transaction.
However, this does add a bit of complexity. Developers need to manage
the db session when calling multiple nested tranactions.

Unit tests have been added to test this functionality and some end to
end tests have been done to make sure all transactions are rollback if
there is an exception while executing the transaction.
This commit is contained in:
Rebecca Law
2021-04-12 13:52:40 +01:00
parent 9a03e579d6
commit cf35135605
11 changed files with 99 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/app/service/test_rest.py
View File

@@ -503,10 +503,10 @@ def test_create_service_should_create_annual_billing_for_service(
assert len(annual_billing) == 1
def test_create_service_should_create_service_if_annual_billing_query_fails(
def test_create_service_should_raise_exception_and_not_create_service_if_annual_billing_query_fails(
admin_request, sample_user, mocker
):
mocker.patch('app.service.rest.set_default_free_allowance_for_service', raises=SQLAlchemyError)
mocker.patch('app.service.rest.set_default_free_allowance_for_service', side_effect=SQLAlchemyError)
data = {
'name': 'created service',
'user_id': str(sample_user.id),
@@ -517,11 +517,12 @@ def test_create_service_should_create_service_if_annual_billing_query_fails(
'created_by': str(sample_user.id)
}
assert len(AnnualBilling.query.all()) == 0
admin_request.post('service.create_service', _data=data, _expected_status=201)
with pytest.raises(expected_exception=SQLAlchemyError):
admin_request.post('service.create_service', _data=data)
annual_billing = AnnualBilling.query.all()
assert len(annual_billing) == 0
assert len(Service.query.filter(Service.name == 'created service').all()) == 1
assert len(Service.query.filter(Service.name == 'created service').all()) == 0
def test_create_service_inherits_branding_from_organisation(