darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-25 08:43:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

If the sms client provider sends more than one delivery receipt only take the update for the the first one.

Browse Source 
Only update the notification.status if status = sending.
This commit is contained in:
Rebecca Law
2016-05-20 17:04:56 +01:00
parent 2b27ca9187
commit cf2723bdc9
4 changed files with 48 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/dao/notifications_dao.py
View File

@@ -219,8 +219,9 @@ def dao_update_notification(notification):
def update_notification_status_by_id(notification_id, status, notification_statistics_status):
count = db.session.query(Notification).filter_by(
id=notification_id
count = db.session.query(Notification).filter(
Notification.id == notification_id,
Notification.status == 'sending'
).update({
Notification.status: status
})

7
app/notifications/process_client_response.py
View File

@@ -58,9 +58,10 @@ def process_sms_client_response(status, reference, client_name):
notification_status,
notification_statistics_status)
if update_success == 0:
status_error = "{} callback failed: notification {} not found. Status {}".format(client_name,
reference,
notification_status_message)
status_error = "{} callback failed: notification {} either not found or already updated " \
"from sending. Status {}".format(client_name,
reference,
notification_status_message)
return success, status_error
if not notification_success: