darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Ensure get_current_provider only returns active

Browse Source
This commit is contained in:
Imdad Ahad
2017-04-24 14:48:06 +01:00
parent 8712b6aa03
commit ce2401c6e0
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/dao/provider_details_dao.py
View File

@@ -36,7 +36,8 @@ def get_alternative_sms_provider(identifier):
def get_current_provider(notification_type): def get_current_provider(notification_type):
return ProviderDetails.query.filter_by( return ProviderDetails.query.filter_by(
notification_type=notification_type notification_type=notification_type,
active=True
).order_by( ).order_by(
asc(ProviderDetails.priority) asc(ProviderDetails.priority)
).first() ).first()

9
tests/app/dao/test_provider_details_dao.py
View File

@@ -273,3 +273,12 @@ def test_get_sms_provider_with_equal_priority_returns_provider(
dao_get_sms_provider_with_equal_priority(current_provider.identifier, current_provider.priority) dao_get_sms_provider_with_equal_priority(current_provider.identifier, current_provider.priority)
assert conflicting_provider assert conflicting_provider
def test_get_current_sms_provider_returns_active_only(restore_provider_details):
current_provider = get_current_provider('sms')
current_provider.active = False
dao_update_provider_details(current_provider)
new_current_provider = get_current_provider('sms')
assert current_provider.identifier != new_current_provider.identifier