darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1839 from alphagov/make-service-stats-7-days-max

Browse Source 
Adjust get_service_stats to get counts for a maximum of 7 days ago
This commit is contained in:
Chris Waszczuk
2018-04-26 15:10:40 +01:00
committed by GitHub
parent f3dc290bcf c157de82c4
commit cc6e4fabe1
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/app/dao/test_services_dao.py
View File

@@ -625,6 +625,29 @@ def test_fetch_stats_for_today_only_includes_today(notify_db, notify_db_session,
assert stats['created'] == 1
def test_fetch_stats_should_not_gather_notifications_older_than_7_days(notify_db, notify_db_session, sample_template):
# 8 days ago
create_notification(notify_db, None, to_field='1', status='delivered', created_at='2001-01-01T12:00:00')
# 7 days ago, 2hours ago
create_notification(notify_db, None, to_field='2', status='failed', created_at='2001-01-02T10:00:00')
# 7 days ago
create_notification(notify_db, None, to_field='2', status='failed', created_at='2001-01-02T12:00:00')
# right_now
create_notification(notify_db, None, to_field='3', status='created', created_at='2001-01-09T12:00:00')
with freeze_time('2001-01-09T12:00:00'):
stats = dao_fetch_stats_for_service(sample_template.service_id)
stats = {row.status: row.count for row in stats}
assert 'delivered' not in stats
assert stats['failed'] == 2
assert stats['created'] == 1
def test_fetch_monthly_historical_stats_separates_months(notify_db, notify_db_session, sample_template):
notification_history = functools.partial(
create_notification_history,