darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-27 02:41:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug with test notifications not showing

Browse Source 
Test notifications are only stored in the notification table, not the
notification_history table. We were deciding which table to query for
the platform admin stats based on the start date passed to the DAO
function. This means that if the start date given was more than 7 days
ago and the end date was within the last 7 days, test notifications were
not being returned. We now use the end date to choose which table to
query which means that test notifications always get returned when they
should.
This commit is contained in:
Katie Smith
2018-06-28 15:02:19 +01:00
parent 4b030b1583
commit cbb9f71e61
2 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -1936,27 +1936,6 @@ def test_notifications_not_yet_sent_return_no_rows(sample_service, notification_
assert len(results) == 0
@pytest.mark.parametrize('table_name, days_ago', [
('Notification', 8),
('NotificationHistory', 3),
])
@freeze_time('2018-01-08')
def test_fetch_aggregate_stats_by_date_range_for_all_services_uses_the_correct_table(
mocker,
notify_db_session,
table_name,
days_ago
):
start_date = datetime.now().date() - timedelta(days=days_ago)
end_date = datetime.now().date()
# mock the table that should not be used, then check it is not being called
unused_table_mock = mocker.patch('app.dao.services_dao.{}'.format(table_name))
fetch_aggregate_stats_by_date_range_for_all_services(start_date, end_date)
unused_table_mock.assert_not_called()
def test_fetch_aggregate_stats_by_date_range_for_all_services_returns_empty_list_when_no_stats(notify_db_session):
start_date = date(2018, 1, 1)
end_date = date(2018, 1, 5)
@@ -2003,3 +1982,17 @@ def test_fetch_aggregate_stats_by_date_range_for_all_services_uses_bst_date(samp
assert len(result) == 1
assert result[0].status == 'sent'
@freeze_time('2018-01-08T12:00:00')
def test_fetch_aggregate_stats_by_date_range_for_all_services_gets_test_notifications_when_start_date_over_7_days_ago(
sample_template
):
ten_days_ago = datetime.utcnow().date() - timedelta(days=10)
today = datetime.utcnow().date()
create_notification(sample_template, key_type=KEY_TYPE_TEST, created_at=datetime.utcnow())
result = fetch_aggregate_stats_by_date_range_for_all_services(ten_days_ago, today)
assert len(result) == 1