Added tests to increase code coverage

tests/app/dao/notification_dao/test_notification_dao.py

@@ -2134,3 +2134,55 @@ def test_sanitize_successful_notification_by_id():
                 "sent_at": ANY,
             },
         )
+
+
+def test_dao_get_notifications_by_recipient_or_reference_covers_sms_search_by_reference(notify_db_session):
+    """
+    This test:
+      1. Creates a service and an SMS template.
+      2. Creates a notification with a specific client_reference and status=FAILED.
+      3. Calls dao_get_notifications_by_recipient_or_reference with notification_type=SMS,
+         statuses=[FAILED], and a search term = client_reference.
+      4. Confirms the function returns exactly one notification matching that reference.
+    """
+
+    service = create_service(service_name="Test Service")
+    template = create_template(service=service, template_type=NotificationType.SMS)
+
+    # Instead of matching phone logic, we'll match on client_reference
+    data = {
+        "id": uuid.uuid4(),
+        "to": "1",
+        "normalised_to": "1",     # phone is irrelevant here
+        "service_id": service.id,
+        "service": service,
+        "template_id": template.id,
+        "template_version": template.version,
+        "status": NotificationStatus.FAILED,
+        "created_at": utc_now(),
+        "billable_units": 1,
+        "notification_type": template.template_type,
+        "key_type": KeyType.NORMAL,
+        "client_reference": "some-ref",  # <--- We'll search for this
+    }
+    notification = Notification(**data)
+    dao_create_notification(notification)
+
+    # We'll search by this reference instead of a phone number
+    search_term = "some-ref"
+
+    results_page = dao_get_notifications_by_recipient_or_reference(
+        service_id=service.id,
+        search_term=search_term,
+        notification_type=NotificationType.SMS,
+        statuses=[NotificationStatus.FAILED],
+        page=1,
+        page_size=50,
+    )
+
+    # Now we should find exactly one match
+    assert len(results_page.items) == 1, "Should find exactly one matching notification"
+    found = results_page.items[0]
+    assert found.id == notification.id
+    assert found.status == NotificationStatus.FAILED
+    assert found.client_reference == "some-ref"

tests/app/dao/test_services_get_specific_hours.py

@@ -7,7 +7,9 @@ from app.dao.services_dao import get_specific_hours_stats
 from app.enums import StatisticsType
 from app.models import TemplateType
 
-NotificationRow = namedtuple("NotificationRow", ["notification_type", "status", "timestamp", "count"])
+NotificationRow = namedtuple(
+    "NotificationRow", ["notification_type", "status", "timestamp", "count"]
+)
 
 
 def generate_expected_hourly_output(requested_sms_hours):
@@ -38,27 +40,31 @@ def create_mock_notification(notification_type, status, timestamp, count=1):
         notification_type=notification_type,
         status=status,
         timestamp=timestamp.replace(minute=0, second=0, microsecond=0),
-        count=count
+        count=count,
     )
 
 
 test_cases = [
     (
-        [create_mock_notification(
-            TemplateType.SMS,
-            StatisticsType.REQUESTED,
-            datetime(2025, 2, 18, 14, 15, 0),
-        )],
+        [
+            create_mock_notification(
+                TemplateType.SMS,
+                StatisticsType.REQUESTED,
+                datetime(2025, 2, 18, 14, 15, 0),
+            )
+        ],
         datetime(2025, 2, 18, 12, 0),
         6,
         generate_expected_hourly_output(["2025-02-18T14:00:00Z"]),
     ),
     (
-        [create_mock_notification(
-            TemplateType.SMS,
-            StatisticsType.REQUESTED,
-            datetime(2025, 2, 18, 17, 59, 59),
-        )],
+        [
+            create_mock_notification(
+                TemplateType.SMS,
+                StatisticsType.REQUESTED,
+                datetime(2025, 2, 18, 17, 59, 59),
+            )
+        ],
         datetime(2025, 2, 18, 15, 0),
         3,
         generate_expected_hourly_output(["2025-02-18T17:00:00Z"]),
@@ -66,21 +72,29 @@ test_cases = [
     ([], datetime(2025, 2, 18, 10, 0), 4, {}),
     (
         [
-            create_mock_notification(TemplateType.SMS, StatisticsType.REQUESTED, datetime(2025, 2, 18, 9, 30, 0)),
-            create_mock_notification(TemplateType.SMS, StatisticsType.REQUESTED, datetime(2025, 2, 18, 11, 45, 0)),
+            create_mock_notification(
+                TemplateType.SMS,
+                StatisticsType.REQUESTED,
+                datetime(2025, 2, 18, 9, 30, 0),
+            ),
+            create_mock_notification(
+                TemplateType.SMS,
+                StatisticsType.REQUESTED,
+                datetime(2025, 2, 18, 11, 45, 0),
+            ),
         ],
         datetime(2025, 2, 18, 8, 0),
         5,
-        generate_expected_hourly_output(["2025-02-18T09:00:00Z", "2025-02-18T11:00:00Z"]),
+        generate_expected_hourly_output(
+            ["2025-02-18T09:00:00Z", "2025-02-18T11:00:00Z"]
+        ),
     ),
 ]
 
 
-@pytest.mark.parametrize("mocked_notifications, start_date, hours, expected_output", test_cases)
+@pytest.mark.parametrize(
+    "mocked_notifications, start_date, hours, expected_output", test_cases
+)
 def test_get_specific_hours(mocked_notifications, start_date, hours, expected_output):
-    results = get_specific_hours_stats(
-        mocked_notifications,
-        start_date,
-        hours=hours
-    )
+    results = get_specific_hours_stats(mocked_notifications, start_date, hours=hours)
     assert results == expected_output, f"Expected {expected_output}, but got {results}"