darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 17:45:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary error handling

Browse Source 
The context here should be enough for the users, custom error
message is not needed.
This commit is contained in:
Pea Tyczynska
2022-01-19 16:17:06 +00:00
parent c2a389e81a
commit c9afb2f038
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/v2/broadcast/post_broadcast.py
View File

@@ -101,17 +101,10 @@ def create_broadcast():
def _cancel_or_reject_broadcast(references_to_original_broadcast, service_id): def _cancel_or_reject_broadcast(references_to_original_broadcast, service_id):
try: broadcast_message = dao_get_broadcast_message_by_references_and_service_id(
broadcast_message = dao_get_broadcast_message_by_references_and_service_id( references_to_original_broadcast,
references_to_original_broadcast, service_id
service_id )
)
except NoResultFound:
raise BadRequestError(
message="Broadcast message reference and service id didn't match with any existing broadcasts",
status_code=404,
)
if broadcast_message.status == BroadcastStatusType.PENDING_APPROVAL: if broadcast_message.status == BroadcastStatusType.PENDING_APPROVAL:
new_status = BroadcastStatusType.REJECTED new_status = BroadcastStatusType.REJECTED
else: else:

3
tests/app/v2/broadcast/test_post_broadcast.py
View File

@@ -234,9 +234,6 @@ def test_cancel_request_does_not_cancel_broadcast_if_reference_does_not_match(
) )
assert response_for_cancel.status_code == 404 assert response_for_cancel.status_code == 404
response = json.loads(response_for_cancel.get_data(as_text=True))
expected_error_message = "Broadcast message reference and service id didn't match with any existing broadcasts"
assert response["errors"][0]["message"] == expected_error_message
def test_large_polygon_is_simplified( def test_large_polygon_is_simplified(