darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Change function and variable names for readability and consistency

Browse Source
This commit is contained in:
Pea Tyczynska
2020-06-01 11:45:35 +01:00
parent a4b942cf6c
commit c96142ba5e
8 changed files with 57 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/clients/sms/firetext.py
View File

@@ -33,13 +33,15 @@ firetext_codes = {
}
def get_firetext_responses(status, code=None):
substatus = firetext_codes[code]['reason'] if firetext_codes.get(code, None) else None
return firetext_responses[status], substatus
def get_firetext_responses(status, detailed_status_code=None):
detailed_status = firetext_codes[detailed_status_code]['reason'] if firetext_codes.get(
detailed_status_code, None
) else None
return (firetext_responses[status], detailed_status)
def get_message_status_and_reason_from_firetext_code(code):
return firetext_codes[code]['status'], firetext_codes[code]['reason']
def get_message_status_and_reason_from_firetext_code(detailed_status_code):
return firetext_codes[detailed_status_code]['status'], firetext_codes[detailed_status_code]['reason']
class FiretextClientResponseException(SmsClientResponseException):

4
app/clients/sms/mmg.py
View File

@@ -45,8 +45,8 @@ mmg_response_map = {
}
def get_mmg_responses(status, substatus=None):
return (mmg_response_map[status]["status"], mmg_response_map[status]["substatus"].get(substatus, None))
def get_mmg_responses(status, detailed_status_code=None):
return (mmg_response_map[status]["status"], mmg_response_map[status]["substatus"].get(detailed_status_code, None))
class MMGClientResponseException(SmsClientResponseException):