From c8db58d0e8d05a78659205053c4a722734ee39ce Mon Sep 17 00:00:00 2001 From: Ben Thorner Date: Mon, 24 Jan 2022 16:02:23 +0000 Subject: [PATCH] Reorder loops for creation status agg sub tasks This will help tailor the innermost loop on services. --- app/celery/reporting_tasks.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/app/celery/reporting_tasks.py b/app/celery/reporting_tasks.py index 5119b76f9..2f74bca10 100644 --- a/app/celery/reporting_tasks.py +++ b/app/celery/reporting_tasks.py @@ -91,12 +91,13 @@ def create_nightly_notification_status(): yesterday = convert_utc_to_bst(datetime.utcnow()).date() - timedelta(days=1) - for (service_id,) in db.session.query(Service.id): - for notification_type in [SMS_TYPE, EMAIL_TYPE, LETTER_TYPE]: - days = 10 if notification_type == LETTER_TYPE else 4 + for notification_type in [SMS_TYPE, EMAIL_TYPE, LETTER_TYPE]: + days = 10 if notification_type == LETTER_TYPE else 4 - for i in range(days): - process_day = yesterday - timedelta(days=i) + for i in range(days): + process_day = yesterday - timedelta(days=i) + + for (service_id,) in db.session.query(Service.id): create_nightly_notification_status_for_service_and_day.apply_async( kwargs={