darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't update older status in timeout notifications task

Browse Source
This commit is contained in:
Imdad Ahad
2017-07-06 11:55:56 +01:00
parent ac9eb29707
commit c8c47f44a9
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/dao/notifications_dao.py
View File

@@ -411,7 +411,7 @@ def _timeout_notifications(current_statuses, new_status, timeout_start, updated_
table.notification_type != LETTER_TYPE table.notification_type != LETTER_TYPE
) )
last_update_count = q.update( last_update_count = q.update(
{'_status_enum': new_status, '_status_fkey': new_status, 'updated_at': updated_at}, {'status': new_status, 'updated_at': updated_at},
synchronize_session=False synchronize_session=False
) )
return last_update_count return last_update_count
@@ -432,8 +432,8 @@ def dao_timeout_notifications(timeout_period_in_seconds):
""" """
timeout_start = datetime.utcnow() - timedelta(seconds=timeout_period_in_seconds) timeout_start = datetime.utcnow() - timedelta(seconds=timeout_period_in_seconds)
updated_at = datetime.utcnow() updated_at = datetime.utcnow()
timeout = functools.partial(_timeout_notifications, timeout_start=timeout_start, updated_at=updated_at) timeout = functools.partial(_timeout_notifications, timeout_start=timeout_start, updated_at=updated_at)
# Notifications still in created status are marked with a technical-failure: # Notifications still in created status are marked with a technical-failure:
updated = timeout([NOTIFICATION_CREATED], NOTIFICATION_TECHNICAL_FAILURE) updated = timeout([NOTIFICATION_CREATED], NOTIFICATION_TECHNICAL_FAILURE)

5
tests/app/celery/test_scheduled_tasks.py
View File

@@ -157,13 +157,8 @@ def test_update_status_of_notifications_after_timeout(notify_api, sample_templat
timeout_notifications() timeout_notifications()
assert not1.status == 'temporary-failure' assert not1.status == 'temporary-failure'
assert not1._status_fkey == 'temporary-failure'
assert not2.status == 'technical-failure' assert not2.status == 'technical-failure'
assert not2._status_fkey == 'technical-failure'
assert not3.status == 'temporary-failure' assert not3.status == 'temporary-failure'
assert not3._status_fkey == 'temporary-failure'
def test_not_update_status_of_notification_before_timeout(notify_api, sample_template): def test_not_update_status_of_notification_before_timeout(notify_api, sample_template):