darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-04 05:30:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

- is_default is required on the add_service_email_reply_to_request schema

Browse Source 
- Added check that the service exists for the POST reply-to methods.
- Added tests
This commit is contained in:
Rebecca Law
2017-09-20 11:58:18 +01:00
parent 34aa541199
commit c6bf38e869
5 changed files with 45 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/service/rest.py
View File

@@ -533,6 +533,8 @@ def get_email_reply_to_addresses(service_id):
@service_blueprint.route('/<uuid:service_id>/email-reply-to', methods=['POST'])
def add_service_reply_to_email_address(service_id):
# validate the service exists, throws ResultNotFound exception.
dao_fetch_service_by_id(service_id)
form = validate(request.get_json(), add_service_email_reply_to_request)
new_reply_to = add_reply_to_email_address_for_service(service_id=service_id,
email_address=form['email_address'],
@@ -540,11 +542,13 @@ def add_service_reply_to_email_address(service_id):
return jsonify(data=new_reply_to.serialize()), 201
@service_blueprint.route('/<uuid:service_id>/email-reply-to/<uuid:id>', methods=['POST'])
def update_service_reply_to_email_address(service_id, id):
@service_blueprint.route('/<uuid:service_id>/email-reply-to/<uuid:reply_to_email_id>', methods=['POST'])
def update_service_reply_to_email_address(service_id, reply_to_email_id):
# validate the service exists, throws ResultNotFound exception.
dao_fetch_service_by_id(service_id)
form = validate(request.get_json(), add_service_email_reply_to_request)
new_reply_to = update_reply_to_email_address(service_id=service_id,
reply_to_id=id,
reply_to_id=reply_to_email_id,
email_address=form['email_address'],
is_default=form.get('is_default', True))
return jsonify(data=new_reply_to.serialize()), 200

2
app/service/service_senders_schema.py
View File

@@ -7,5 +7,5 @@ add_service_email_reply_to_request = {
"email_address": {"type": "string", "format": "email_address"},
"is_default": {"type": "boolean"}
},
"required": ["email_address"]
"required": ["email_address", "is_default"]
}