darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don’t let admin specify branding for new service

Browse Source 
It doesn’t need to because the API code works it all out now by looking
at the organisation.
This commit is contained in:
Chris Hill-Scott
2019-04-12 15:35:51 +01:00
parent ee966668bd
commit c6447c111d
2 changed files with 3 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/dao/test_services_dao.py
View File

@@ -102,25 +102,6 @@ def test_create_service(notify_db_session):
assert not service.letter_branding
def test_create_service_with_letter_branding(notify_db_session):
user = create_user()
create_letter_branding()
letter_branding = create_letter_branding(
name='test domain', filename='test-domain',
)
assert Service.query.count() == 0
service = Service(name="service_name",
email_from="email_from",
message_limit=1000,
restricted=False,
organisation_type='central',
created_by=user)
dao_create_service(service, user, letter_branding=letter_branding)
service_db = Service.query.one()
assert service_db.id == service.id
assert service.letter_branding == letter_branding
@pytest.mark.parametrize('email_address, organisation_type', (
("test@example.gov.uk", 'nhs'),
("test@nhs.net", 'nhs'),
@@ -155,7 +136,7 @@ def test_create_nhs_service_get_default_branding_based_on_email_address(
organisation_type=organisation_type,
created_by=user,
)
dao_create_service(service, user, letter_branding=letter_branding)
dao_create_service(service, user)
service_db = Service.query.one()
if expected_branding: