darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use service_id in the query to make it safer, also use named parameters

Browse Source
This commit is contained in:
Pea Tyczynska
2019-09-25 15:48:28 +01:00
parent 8cf8d24e37
commit c48aa77dd5
4 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -564,7 +564,7 @@ def test_dao_get_notification_count_for_job_id(notify_db_session, notify_db):
create_notification(template)
assert dao_get_notification_count_for_job_id(job.id) == 3
assert dao_get_notification_count_for_job_id(service_id=service.id, job_id=job.id) == 3
def test_dao_get_notification_count_for_job_id_only_finds_notification_already_in_db(notify_db_session, notify_db):
@@ -573,7 +573,18 @@ def test_dao_get_notification_count_for_job_id_only_finds_notification_already_i
job = create_job(template, notification_count=3)
create_notification(template)
assert dao_get_notification_count_for_job_id(job.id) == 0
assert dao_get_notification_count_for_job_id(service_id=service.id, job_id=job.id) == 0
def test_dao_get_notification_count_for_job_id_doesnt_work_with_non_existing_service_id(notify_db_session, notify_db):
service = create_service()
template = create_template(service)
job = create_job(template, notification_count=3)
for i in range(3):
create_notification(job=job)
fake_service_id = str(uuid.uuid4())
assert dao_get_notification_count_for_job_id(service_id=fake_service_id, job_id=job.id) == 0
def test_update_notification_sets_status(sample_notification):