darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use service_id in the query to make it safer, also use named parameters

Browse Source
This commit is contained in:
Pea Tyczynska
2019-09-25 15:48:28 +01:00
parent 8cf8d24e37
commit c48aa77dd5
4 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/dao/notifications_dao.py
View File

@@ -179,8 +179,8 @@ def get_notifications_for_job(service_id, job_id, filter_dict=None, page=1, page
@statsd(namespace="dao")
def dao_get_notification_count_for_job_id(job_id):
return Notification.query.filter_by(job_id=job_id).count()
def dao_get_notification_count_for_job_id(*, service_id, job_id):
return Notification.query.filter_by(service_id=service_id, job_id=job_id).count()
@statsd(namespace="dao")