darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2386 from alphagov/missing-ses-receipt-warning

Browse Source 
Downgrade log level for missing notifications in SES receipt
This commit is contained in:
Alexey Bezhan
2019-03-06 12:50:33 +00:00
committed by GitHub
parent a355a98442 6f5822ae5b
commit c43b03634e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/celery/process_ses_receipts_tasks.py
View File

@@ -42,10 +42,10 @@ def process_ses_results(self, response):
notification = notifications_dao.dao_get_notification_by_reference(reference) notification = notifications_dao.dao_get_notification_by_reference(reference)
except NoResultFound: except NoResultFound:
message_time = iso8601.parse_date(ses_message['mail']['timestamp']).replace(tzinfo=None) message_time = iso8601.parse_date(ses_message['mail']['timestamp']).replace(tzinfo=None)
if datetime.utcnow() - message_time < timedelta(minutes=10): if datetime.utcnow() - message_time < timedelta(minutes=5):
self.retry(queue=QueueNames.RETRY) self.retry(queue=QueueNames.RETRY)
elif datetime.utcnow() - message_time < timedelta(days=3): else:
current_app.logger.error( current_app.logger.warning(
"notification not found for reference: {} (update to {})".format(reference, notification_status) "notification not found for reference: {} (update to {})".format(reference, notification_status)
) )
return return

2
tests/app/celery/test_process_ses_receipts_tasks.py
View File

@@ -117,7 +117,7 @@ def test_ses_callback_should_retry_if_notification_is_new(client, notify_db, moc
def test_ses_callback_should_log_if_notification_is_missing(client, notify_db, mocker): def test_ses_callback_should_log_if_notification_is_missing(client, notify_db, mocker):
mock_retry = mocker.patch('app.celery.process_ses_receipts_tasks.process_ses_results.retry') mock_retry = mocker.patch('app.celery.process_ses_receipts_tasks.process_ses_results.retry')
mock_logger = mocker.patch('app.celery.process_ses_receipts_tasks.current_app.logger.error') mock_logger = mocker.patch('app.celery.process_ses_receipts_tasks.current_app.logger.warning')
with freeze_time('2017-11-17T12:34:03.646Z'): with freeze_time('2017-11-17T12:34:03.646Z'):
assert process_ses_results(ses_notification_callback(reference='ref')) is None assert process_ses_results(ses_notification_callback(reference='ref')) is None