darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 05:58:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cleaning & debugging

Browse Source 
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
This commit is contained in:
Cliff Hill
2024-02-27 10:24:20 -05:00
parent 75cec3a635
commit c407d61d60
8 changed files with 62 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/app/v2/notifications/test_get_notifications.py
View File

@@ -408,9 +408,12 @@ def test_get_all_notifications_filter_by_template_type_invalid_template_type(
assert json_response["status_code"] == 400
assert len(json_response["errors"]) == 1
type_str = ", ".join(
[f"<{type(e).__name__}.{e.name}: {e.value}>" for e in TemplateType]
)
assert (
json_response["errors"][0]["message"]
== f"template_type orange is not one of [{', '.join([f'<{type(e).__name__}.{e.name}: {e.value}>'for e in TemplateType])}]"
== f"template_type orange is not one of [{type_str}]"
)
@@ -461,9 +464,12 @@ def test_get_all_notifications_filter_by_status_invalid_status(
assert json_response["status_code"] == 400
assert len(json_response["errors"]) == 1
type_str = ", ".join(
[f"<{type(e).__name__}.{e.name}: {e.value}>" for e in NotificationStatus]
)
assert (
json_response["errors"][0]["message"]
== f"status elephant is not one of [{', '.join([f'<{type(e).__name__}.{e.name}: {e.value}>'for e in NotificationStatus])}]"
== f"status elephant is not one of [{type_str}]"
)

23
tests/app/v2/notifications/test_notification_schemas.py
View File

@@ -43,7 +43,10 @@ def test_get_notifications_valid_json(input):
],
)
def test_get_notifications_request_invalid_statuses(invalid_statuses, valid_statuses):
partial_error_status = f"is not one of [{', '.join([f'<{type(e).__name__}.{e.name}: {e.value}>'for e in NotificationStatus])}]"
type_str = ", ".join(
[f"<{type(e).__name__}.{e.name}: {e.value}>" for e in NotificationStatus]
)
partial_error_status = f"is not one of [{type_str}]"
with pytest.raises(ValidationError) as e:
validate(
@@ -70,7 +73,10 @@ def test_get_notifications_request_invalid_statuses(invalid_statuses, valid_stat
def test_get_notifications_request_invalid_template_types(
invalid_template_types, valid_template_types
):
partial_error_template_type = f"is not one of [{', '.join([f'<{type(e).__name__}.{e.name}: {e.value}>'for e in TemplateType])}]"
type_str = ", ".join(
[f"<{type(e).__name__}.{e.name}: {e.value}>" for e in TemplateType]
)
partial_error_template_type = f"is not one of [{type_str}]"
with pytest.raises(ValidationError) as e:
validate(
@@ -101,15 +107,18 @@ def test_get_notifications_request_invalid_statuses_and_template_types():
assert len(errors) == 4
error_messages = [error["message"] for error in errors]
type_str = ", ".join(
[f"<{type(e).__name__}.{e.name}: {e.value}>" for e in NotificationStatus]
)
for invalid_status in ["elephant", "giraffe"]:
assert (
f"status {invalid_status} is not one of [{', '.join([f'<{type(e).__name__}.{e.name}: {e.value}>'for e in NotificationStatus])}]"
in error_messages
)
assert f"status {invalid_status} is not one of [{type_str}]" in error_messages
type_str = ", ".join(
[f"<{type(e).__name__}.{e.name}: {e.value}>" for e in TemplateType]
)
for invalid_template_type in ["orange", "avocado"]:
assert (
f"template_type {invalid_template_type} is not one of [{', '.join([f'<{type(e).__name__}.{e.name}: {e.value}>'for e in TemplateType])}]"
f"template_type {invalid_template_type} is not one of [{type_str}]"
in error_messages
)