darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 16:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary test_request_context manager

Browse Source 
This doesn't affect how the tests run and just adds complexity.
This commit is contained in:
Ben Thorner
2021-11-25 17:59:37 +00:00
parent 05bd26d444
commit c3e11d676f
1 changed files with 26 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
tests/app/celery/test_nightly_tasks.py
View File

@@ -167,37 +167,35 @@ def test_delete_letter_notifications_older_than_retention_calls_child_task(notif
def test_timeout_notifications_after_timeout(notify_api, sample_template): def test_timeout_notifications_after_timeout(notify_api, sample_template):
with notify_api.test_request_context(): not1 = create_notification(
not1 = create_notification( template=sample_template,
template=sample_template, status='sending',
status='sending', created_at=datetime.utcnow() - timedelta(
created_at=datetime.utcnow() - timedelta( seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') + 10))
seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') + 10)) not2 = create_notification(
not2 = create_notification( template=sample_template,
template=sample_template, status='created',
status='created', created_at=datetime.utcnow() - timedelta(
created_at=datetime.utcnow() - timedelta( seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') + 10))
seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') + 10)) not3 = create_notification(
not3 = create_notification( template=sample_template,
template=sample_template, status='pending',
status='pending', created_at=datetime.utcnow() - timedelta(
created_at=datetime.utcnow() - timedelta( seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') + 10))
seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') + 10)) timeout_notifications()
timeout_notifications() assert not1.status == 'temporary-failure'
assert not1.status == 'temporary-failure' assert not2.status == 'created'
assert not2.status == 'created' assert not3.status == 'temporary-failure'
assert not3.status == 'temporary-failure'
def test_timeout_notifications_before_timeout(notify_api, sample_template): def test_timeout_notifications_before_timeout(notify_api, sample_template):
with notify_api.test_request_context(): not1 = create_notification(
not1 = create_notification( template=sample_template,
template=sample_template, status='sending',
status='sending', created_at=datetime.utcnow() - timedelta(
created_at=datetime.utcnow() - timedelta( seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') - 10))
seconds=current_app.config.get('SENDING_NOTIFICATIONS_TIMEOUT_PERIOD') - 10)) timeout_notifications()
timeout_notifications() assert not1.status == 'sending'
assert not1.status == 'sending'
def test_timeout_notifications_avoids_letters(client, sample_letter_template): def test_timeout_notifications_avoids_letters(client, sample_letter_template):