- Add validation methods for post notification.

- Use these validation methods in post_sms_notification and the version 1 of post_notification.
- Create a v2 error handlers.
- InvalidRequest has a to_dict method for private and v1 error responses and a to_dict_v2 method to create the v2 of the error responses.
- Each validation method has extensive unit tests, so the unit test for the endpoint do not need to check every error case, but check that the error handle formats the message correctly.
- The format of the error messages is still a work on progress.
- This version of the api could be deployed without causing a problem to the application.
- The new endpoing is still a work in progress and is not being used yet.

tests/app/notifications/test_process_notification.py

@@ -0,0 +1,17 @@
+import pytest
+
+from app.models import Template
+from app.notifications.process_notifications import create_content_for_notification
+from app.v2.errors import BadRequestError
+
+
+def test_create_content_for_notification_passes(sample_email_template):
+    template = Template.query.get(sample_email_template.id)
+    content = create_content_for_notification(template, None)
+    assert content.content == template.content
+
+
+def test_create_content_for_notification_fails_with_missing_personalisation(sample_template_with_placeholders):
+    template = Template.query.get(sample_template_with_placeholders.id)
+    with pytest.raises(BadRequestError):
+        create_content_for_notification(template, None)