darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Auto switch providers if exception is returned on sms delivery

Browse Source
This commit is contained in:
Imdad Ahad
2017-01-17 15:46:02 +00:00
parent 2896ed27f2
commit c221118669
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/provider_tasks.py
View File

@@ -5,6 +5,7 @@ from sqlalchemy.orm.exc import NoResultFound
from app import notify_celery from app import notify_celery
from app.dao import notifications_dao from app.dao import notifications_dao
from app.dao.notifications_dao import update_notification_status_by_id from app.dao.notifications_dao import update_notification_status_by_id
from app.dao.provider_details_dao import dao_toggle_sms_provider
from app.statsd_decorators import statsd from app.statsd_decorators import statsd
from app.delivery import send_to_providers from app.delivery import send_to_providers
@@ -43,6 +44,7 @@ def deliver_sms(self, notification_id):
send_to_providers.send_sms_to_provider(notification) send_to_providers.send_sms_to_provider(notification)
except Exception as e: except Exception as e:
try: try:
dao_toggle_sms_provider()
current_app.logger.exception( current_app.logger.exception(
"RETRY: SMS notification {} failed".format(notification_id) "RETRY: SMS notification {} failed".format(notification_id)
) )

10
tests/app/celery/test_provider_tasks.py
View File

@@ -121,3 +121,13 @@ def test_should_technical_error_and_not_retry_if_invalid_email(sample_notificati
assert provider_tasks.deliver_email.retry.called is False assert provider_tasks.deliver_email.retry.called is False
assert sample_notification.status == 'technical-failure' assert sample_notification.status == 'technical-failure'
def test_send_sms_should_switch_providers_on_provider_failure(sample_notification, mocker):
mocker.patch('app.delivery.send_to_providers.send_sms_to_provider', side_effect=Exception("Provider Exception"))
switch_provider_mock = mocker.patch('app.celery.provider_tasks.dao_toggle_sms_provider')
mocker.patch('app.celery.provider_tasks.deliver_sms.retry')
deliver_sms(sample_notification.service_id)
assert switch_provider_mock.called is True