From 87cb02fa1d9088beacdd528db7b610b2844ae7bc Mon Sep 17 00:00:00 2001 From: David McDonald Date: Mon, 30 Mar 2020 12:07:05 +0100 Subject: [PATCH] Add runbook link to resolve letters pending virus scan --- app/celery/scheduled_tasks.py | 5 +++-- tests/app/celery/test_scheduled_tasks.py | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/celery/scheduled_tasks.py b/app/celery/scheduled_tasks.py index e0c419534..f03c95511 100644 --- a/app/celery/scheduled_tasks.py +++ b/app/celery/scheduled_tasks.py @@ -216,8 +216,9 @@ def check_precompiled_letter_state(): if len(letters) > 0: letter_ids = [str(letter.id) for letter in letters] - msg = "{} precompiled letters have been pending-virus-check for over 90 minutes. " \ - "Notifications: {}".format(len(letters), letter_ids) + msg = """{} precompiled letters have been pending-virus-check for over 90 minutes. Follow runbook to resolve: + https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#Deal-with-letter-pending-virus-scan-for-90-minutes. + Notifications: {}""".format(len(letters), letter_ids) current_app.logger.exception(msg) diff --git a/tests/app/celery/test_scheduled_tasks.py b/tests/app/celery/test_scheduled_tasks.py index bb43251c6..17d465e0b 100644 --- a/tests/app/celery/test_scheduled_tasks.py +++ b/tests/app/celery/test_scheduled_tasks.py @@ -373,8 +373,9 @@ def test_check_precompiled_letter_state(mocker, sample_letter_template): check_precompiled_letter_state() - message = "2 precompiled letters have been pending-virus-check for over 90 minutes. " \ - "Notifications: ['{}', '{}']".format(noti_2.id, noti_1.id) + message = """2 precompiled letters have been pending-virus-check for over 90 minutes. Follow runbook to resolve: + https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#Deal-with-letter-pending-virus-scan-for-90-minutes. + Notifications: ['{}', '{}']""".format(noti_2.id, noti_1.id) mock_logger.assert_called_once_with(message) mock_create_ticket.assert_called_with(