darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed some linting errors

Browse Source
This commit is contained in:
alexjanousekGSA
2025-05-16 14:14:50 -04:00
parent 56bcf0dd68
commit c1507ec060
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/public_schemas/public.py
View File

@@ -1,10 +1,8 @@
from datetime import timezone, datetime from datetime import datetime, timezone
from uuid import UUID from uuid import UUID
from marshmallow import EXCLUDE, Schema, fields, post_dump, pre_dump from marshmallow import EXCLUDE, Schema, fields, post_dump
from app.schemas import FlexibleDateTime, JobSchema, TemplateSchema
from app import ma
class PublicTemplateSchema(Schema): class PublicTemplateSchema(Schema):
id = fields.UUID(required=True) id = fields.UUID(required=True)
@@ -63,7 +61,9 @@ class PublicNotificationResponseSchema(PublicNotificationSchema):
# Fallback content # Fallback content
template = data.get("template", {}) template = data.get("template", {})
body = data.get("body") or (template.get("content") if isinstance(template, dict) else "") body = data.get("body") or (
template.get("content") if isinstance(template, dict) else ""
)
data["body"] = body or "" data["body"] = body or ""
data["content_char_count"] = len(data["body"]) data["content_char_count"] = len(data["body"])

2
app/schemas.py
View File

@@ -20,7 +20,7 @@ from app import ma, models
from app.dao.permissions_dao import permission_dao from app.dao.permissions_dao import permission_dao
from app.enums import NotificationStatus, ServicePermissionType, TemplateType from app.enums import NotificationStatus, ServicePermissionType, TemplateType
from app.models import ServicePermission from app.models import ServicePermission
from app.utils import DATETIME_FORMAT_NO_TIMEZONE, get_template_instance, utc_now from app.utils import DATETIME_FORMAT_NO_TIMEZONE, utc_now
from notifications_utils.recipients import ( from notifications_utils.recipients import (
InvalidEmailError, InvalidEmailError,
InvalidPhoneError, InvalidPhoneError,

7
tests/app/public_contracts/test_GET_notification.py
View File

@@ -1,5 +1,3 @@
import pytest
from app.dao.api_key_dao import save_model_api_key from app.dao.api_key_dao import save_model_api_key
from app.enums import KeyType from app.enums import KeyType
from app.models import ApiKey from app.models import ApiKey
@@ -46,8 +44,9 @@ def test_get_job_sms_contract(client, sample_notification):
validate_v0(response_json, "GET_notification_return_sms.json") validate_v0(response_json, "GET_notification_return_sms.json")
def test_get_notifications_contract(
def test_get_notifications_contract(client, sample_notification, sample_email_notification): client, sample_notification, sample_email_notification
):
response_json = return_json_from_response( response_json = return_json_from_response(
_get_notification(client, sample_notification, "/notifications") _get_notification(client, sample_notification, "/notifications")
) )