darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-10 10:03:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

move statsd call out of generic tryexcept

Browse Source 
we shouldn't try and use statsd to log an error if they fail, for example

[we also shouldn't retry sending the message but that's a problem for another time]
This commit is contained in:
Leo Hemsted
2016-10-13 14:17:17 +01:00
parent 2f12ad987d
commit c0c62e02b7
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/clients/email/aws_ses.py
View File

@@ -90,13 +90,15 @@ class AwsSesClient(EmailClient):
}, },
'Body': body 'Body': body
}, },
ReplyToAddresses=reply_to_addresses) ReplyToAddresses=reply_to_addresses
)
except Exception as e:
# TODO logging exceptions
self.statsd_client.incr("clients.ses.error")
raise AwsSesClientException(str(e))
elapsed_time = monotonic() - start_time elapsed_time = monotonic() - start_time
current_app.logger.info("AWS SES request finished in {}".format(elapsed_time)) current_app.logger.info("AWS SES request finished in {}".format(elapsed_time))
self.statsd_client.timing("clients.ses.request-time", elapsed_time) self.statsd_client.timing("clients.ses.request-time", elapsed_time)
self.statsd_client.incr("clients.ses.success") self.statsd_client.incr("clients.ses.success")
return response['MessageId'] return response['MessageId']
except Exception as e:
# TODO logging exceptions
self.statsd_client.incr("clients.ses.error")
raise AwsSesClientException(str(e))