diff --git a/app/celery/letters_pdf_tasks.py b/app/celery/letters_pdf_tasks.py index 0f26c1fdc..6e9bc6210 100644 --- a/app/celery/letters_pdf_tasks.py +++ b/app/celery/letters_pdf_tasks.py @@ -123,8 +123,7 @@ def update_validation_failed_for_templated_letter(self, notification_id, page_co notification = get_notification_by_id(notification_id, _raise=True) notification.status = NOTIFICATION_VALIDATION_FAILED dao_update_notification(notification) - current_app.logger.info(f"Letter notification id: {notification_id} reference {notification.reference}: " - f"validation failed: letter is too long {page_count}") + current_app.logger.info(f"Validation failed: letter is too long {page_count} for letter with id: {notification_id}") @notify_celery.task(name='collate-letter-pdfs-to-be-sent') diff --git a/tests/app/celery/test_letters_pdf_tasks.py b/tests/app/celery/test_letters_pdf_tasks.py index 1de2d8379..a2419508a 100644 --- a/tests/app/celery/test_letters_pdf_tasks.py +++ b/tests/app/celery/test_letters_pdf_tasks.py @@ -190,8 +190,7 @@ def test_update_validation_failed_for_templated_letter_with_too_many_pages( assert sample_letter_notification.billable_units == 0 assert sample_letter_notification.status == NOTIFICATION_VALIDATION_FAILED mock_logger.assert_called_once_with( - f"Letter notification id: {sample_letter_notification.id} reference {sample_letter_notification.reference}: " - f"validation failed: letter is too long 11" + f"Validation failed: letter is too long 11 for letter with id: {sample_letter_notification.id}" )