darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

ensure the user_number in inbound sms is international

Browse Source 
rather than using the `normalise_phone_number` function, use the
`validate_and_format_phone_number` function - this will also convert
all numbers to international format, which means we won't need to
worry about whether the user enters internaional or UK phone numbers
when searching
This commit is contained in:
Leo Hemsted
2017-06-02 12:57:28 +01:00
parent ef52337d85
commit bf18b179b0
5 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/notifications/receive_notifications.py
View File

@@ -2,7 +2,7 @@ from urllib.parse import unquote
import iso8601
from flask import jsonify, Blueprint, current_app, request
from notifications_utils.recipients import normalise_phone_number
from notifications_utils.recipients import validate_and_format_phone_number
from app import statsd_client
from app.dao.services_dao import dao_fetch_services_by_sms_sender
@@ -64,8 +64,8 @@ def format_mmg_datetime(date):
def create_inbound_mmg_sms_object(service, json):
message = format_mmg_message(json['Message'])
user_number = normalise_phone_number(json['MSISDN'])
message = format_message(json['Message'])
user_number = validate_and_format_phone_number(json['MSISDN'])
provider_date = json.get('DateRecieved')
if provider_date: