darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-16 20:48:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

More cleanup.

Browse Source 
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
This commit is contained in:
Cliff Hill
2024-01-16 15:47:55 -05:00
parent 26bc6198f8
commit bd705ed188
9 changed files with 38 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/conftest.py
View File

@@ -129,7 +129,7 @@ def create_sample_notification(
"key_type": api_key.key_type if api_key else key_type,
"sent_by": sent_by,
"updated_at": created_at
if status in NotificationStatus.completed_types
if status in NotificationStatus.completed_types()
else None,
"client_reference": client_reference,
"rate_multiplier": rate_multiplier,

8
tests/app/test_model.py
View File

@@ -74,11 +74,11 @@ def test_should_not_build_service_guest_list_from_invalid_contact(
"initial_statuses, expected_statuses",
[
# passing in single statuses as strings
(NotificationStatus.FAILED, NotificationStatus.failed_types),
(NotificationStatus.FAILED, NotificationStatus.failed_types()),
(NotificationStatus.CREATED, [NotificationStatus.CREATED]),
(NotificationStatus.TECHNICAL_FAILURE, [NotificationStatus.TECHNICAL_FAILURE]),
# passing in lists containing single statuses
([NotificationStatus.FAILED], NotificationStatus.failed_types),
([NotificationStatus.FAILED], NotificationStatus.failed_types()),
([NotificationStatus.CREATED], [NotificationStatus.CREATED]),
(
[NotificationStatus.TECHNICAL_FAILURE],
@@ -87,7 +87,7 @@ def test_should_not_build_service_guest_list_from_invalid_contact(
# passing in lists containing multiple statuses
(
[NotificationStatus.FAILED, NotificationStatus.CREATED],
list(NotificationStatus.failed_types) + [NotificationStatus.CREATED],
list(NotificationStatus.failed_types()) + [NotificationStatus.CREATED],
),
(
[NotificationStatus.CREATED, NotificationStatus.PENDING],
@@ -104,7 +104,7 @@ def test_should_not_build_service_guest_list_from_invalid_contact(
NotificationStatus.CREATED,
NotificationStatus.TECHNICAL_FAILURE,
],
list(NotificationStatus.failed_types) + [NotificationStatus.CREATED],
list(NotificationStatus.failed_types()) + [NotificationStatus.CREATED],
),
],
)