darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bump utils version which contains ~ as an invalid first character for a

Browse Source 
postal address.
This commit is contained in:
Rebecca Law
2021-05-25 07:57:51 +01:00
parent 70ff00f2c3
commit bd1498f49f
4 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notifications/validators.py
View File

@@ -265,7 +265,7 @@ def validate_address(service, letter_data):
) )
if address.has_invalid_characters: if address.has_invalid_characters:
raise ValidationError( raise ValidationError(
message='Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / , < >' message='Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / , < > ~'
) )
if address.international: if address.international:
return address.postage return address.postage

2
requirements-app.txt
View File

@@ -34,7 +34,7 @@ notifications-python-client==6.0.2
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
git+https://github.com/alphagov/notifications-utils.git@44.1.0#egg=notifications-utils==44.1.0 git+https://github.com/alphagov/notifications-utils.git@44.2.1#egg=notifications-utils==44.2.1
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.10.1 prometheus-client==0.10.1

24
requirements.txt
View File

@@ -36,29 +36,30 @@ notifications-python-client==6.0.2
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
git+https://github.com/alphagov/notifications-utils.git@44.1.0#egg=notifications-utils==44.1.0 git+https://github.com/alphagov/notifications-utils.git@44.2.1#egg=notifications-utils==44.2.1
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.10.1 prometheus-client==0.10.1
gds-metrics==0.2.4 gds-metrics==0.2.4
## The following requirements were added by pip freeze: ## The following requirements were added by pip freeze:
alembic==1.6.2 alembic==1.6.3
amqp==1.4.9 amqp==1.4.9
anyjson==0.3.3 anyjson==0.3.3
attrs==21.2.0 attrs==21.2.0
awscli==1.19.69 awscli==1.19.78
bcrypt==3.2.0 bcrypt==3.2.0
billiard==3.3.0.23 billiard==3.3.0.23
bleach==3.3.0 bleach==3.3.0
blinker==1.4 blinker==1.4
boto==2.49.0 boto==2.49.0
boto3==1.17.69 boto3==1.17.78
botocore==1.20.69 botocore==1.20.78
certifi==2020.12.5 certifi==2020.12.5
chardet==4.0.0 chardet==4.0.0
click==7.1.2 click==8.0.1
colorama==0.4.3 colorama==0.4.3
dataclasses==0.8
dnspython==1.16.0 dnspython==1.16.0
docutils==0.15.2 docutils==0.15.2
flask-redis==0.4.0 flask-redis==0.4.0
@@ -66,15 +67,16 @@ geojson==2.5.0
govuk-bank-holidays==0.8 govuk-bank-holidays==0.8
greenlet==1.1.0 greenlet==1.1.0
idna==2.10 idna==2.10
Jinja2==2.11.3 importlib-metadata==4.0.1
Jinja2==3.0.1
jmespath==0.10.0 jmespath==0.10.0
kombu==3.0.37 kombu==3.0.37
Mako==1.1.4 Mako==1.1.4
MarkupSafe==1.1.1 MarkupSafe==2.0.1
mistune==0.8.4 mistune==0.8.4
orderedset==2.0.3 orderedset==2.0.3
packaging==20.9 packaging==20.9
phonenumbers==8.12.22 phonenumbers==8.12.23
pyasn1==0.4.8 pyasn1==0.4.8
pycparser==2.20 pycparser==2.20
pyparsing==2.4.7 pyparsing==2.4.7
@@ -94,6 +96,8 @@ six==1.16.0
smartypants==2.0.1 smartypants==2.0.1
soupsieve==2.2.1 soupsieve==2.2.1
statsd==3.3.0 statsd==3.3.0
typing-extensions==3.10.0.0
urllib3==1.26.4 urllib3==1.26.4
webencodings==0.5.1 webencodings==0.5.1
Werkzeug==1.0.1 Werkzeug==2.0.1
zipp==3.4.1

2
tests/app/v2/notifications/test_post_letter_notifications.py
View File

@@ -222,7 +222,7 @@ def test_post_letter_notification_international_sets_rest_of_world(
'postcode': 'SW1A 1AA', 'postcode': 'SW1A 1AA',
'name': 'Lizzie' 'name': 'Lizzie'
}, },
'Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / , < >', 'Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / , < > ~',
), ),
( (
[LETTER_TYPE, INTERNATIONAL_LETTERS], [LETTER_TYPE, INTERNATIONAL_LETTERS],