darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-07-09 10:53:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

notify-api-521 fix sms temporary failure message

Browse Source
This commit is contained in:
Kenneth Kehl
2023-10-02 14:09:50 -07:00
parent 819cbb3353
commit bd09c63ea9
5 changed files with 42 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/celery/test_provider_tasks.py
View File

@@ -105,7 +105,7 @@ def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_sms_task(
queue="retry-tasks", countdown=0
)
assert sample_notification.status == "technical-failure"
assert sample_notification.status == "temporary-failure"
assert mock_logger_exception.called

8
tests/app/test_model.py
View File

@@ -139,8 +139,12 @@ def test_notification_for_csv_returns_correct_job_row_number(sample_job):
("email", "technical-failure", "Technical failure"),
("email", "temporary-failure", "Inbox not accepting messages right now"),
("email", "permanent-failure", "Email address doesn’t exist"),
("sms", "temporary-failure", "Phone not accepting messages right now"),
("sms", "permanent-failure", "Phone number doesn’t exist"),
(
"sms",
"temporary-failure",
"Unable to find carrier response -- still looking",
),
("sms", "permanent-failure", "Unable to find carrier response."),
("sms", "sent", "Sent internationally"),
],
)