darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 08:16:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

don't log exception info for retries

Browse Source 
it includes task args, which might contain PII. And we don't need to
know where the retry exception came from - it came from the line above
This commit is contained in:
Leo Hemsted
2018-10-22 11:11:07 +01:00
parent 6c613484ef
commit bc3fab09d0
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/celery/letters_pdf_tasks.py
View File

@@ -74,7 +74,7 @@ def create_letters_pdf(self, notification_id):
)
self.retry(queue=QueueNames.RETRY)
except MaxRetriesExceededError:
current_app.logger.exception(
current_app.logger.error(
"RETRY FAILED: task create_letters_pdf failed for notification {}".format(notification_id),
)
update_notification_status_by_id(notification_id, 'technical-failure')
@@ -259,7 +259,7 @@ def _sanitise_precompiled_pdf(self, notification, precompiled_pdf):
)
self.retry(queue=QueueNames.RETRY)
except MaxRetriesExceededError:
current_app.logger.exception(
current_app.logger.error(
"RETRY FAILED: sanitise_precompiled_pdf failed for notification {}".format(notification.id),
)