darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-08 16:43:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Return 400 if references missing from cancel broadcast

Browse Source 
If someone tries to cancel a broadcast but the references don’t match
and existing broadcast we correctly return a 404.

If they don’t provide any references then we get an exception. This
commit catches the missing references and returns a 400. I think this
is more appropriate because it’s malformed request, rather than a
well-formed request that doesn’t match our data. It also lets us write a
more specific and helpful error message.
This commit is contained in:
Chris Hill-Scott
2022-02-14 12:22:54 +00:00
parent 5a87d8c7d7
commit bbc444699a
4 changed files with 47 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/app/v2/broadcast/test_post_broadcast.py
View File

@@ -156,7 +156,7 @@ def test_valid_cancel_broadcast_request_calls_validate_and_update_broadcast_mess
# cancel broadcast
response_for_cancel = client.post(
path='/v2/broadcast',
data=sample_cap_xml_documents.WAINFLEET_CANCEL,
data=sample_cap_xml_documents.WAINFLEET_CANCEL_WITH_REFERENCES,
headers=[('Content-Type', 'application/cap+xml'), auth_header],
)
assert response_for_cancel.status_code == 201
@@ -167,9 +167,29 @@ def test_valid_cancel_broadcast_request_calls_validate_and_update_broadcast_mess
)
@pytest.mark.parametrize('cap_xml_document, expected_status, expected_error', (
(
sample_cap_xml_documents.WAINFLEET_CANCEL_WITH_REFERENCES,
404,
[{'error': 'NoResultFound', 'message': 'No result found'}],
),
(
sample_cap_xml_documents.WAINFLEET_CANCEL_WITH_EMPTY_REFERENCES,
404,
[{'error': 'NoResultFound', 'message': 'No result found'}],
),
(
sample_cap_xml_documents.WAINFLEET_CANCEL_WITH_MISSING_REFERENCES,
400,
[{'error': 'BadRequestError', 'message': 'Missing <references>'}],
),
))
def test_cancel_request_does_not_cancel_broadcast_if_reference_does_not_match(
client,
sample_broadcast_service
sample_broadcast_service,
cap_xml_document,
expected_status,
expected_error,
):
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
@@ -191,11 +211,13 @@ def test_cancel_request_does_not_cancel_broadcast_if_reference_does_not_match(
# try to cancel broadcast, but reference doesn't match
response_for_cancel = client.post(
path='/v2/broadcast',
data=sample_cap_xml_documents.WAINFLEET_CANCEL,
data=cap_xml_document,
headers=[('Content-Type', 'application/cap+xml'), auth_header],
)
response_for_cancel_json = json.loads(response_for_cancel.get_data(as_text=True))
assert response_for_cancel.status_code == 404
assert response_for_cancel.status_code == expected_status
assert response_for_cancel_json["errors"] == expected_error
def test_cancel_request_does_not_cancel_broadcast_if_service_id_does_not_match(
@@ -224,7 +246,7 @@ def test_cancel_request_does_not_cancel_broadcast_if_service_id_does_not_match(
auth_header_2 = create_service_authorization_header(service_id=sample_broadcast_service_2.id)
response_for_cancel = client.post(
path='/v2/broadcast',
data=sample_cap_xml_documents.WAINFLEET_CANCEL,
data=sample_cap_xml_documents.WAINFLEET_CANCEL_WITH_REFERENCES,
headers=[('Content-Type', 'application/cap+xml'), auth_header_2],
)