darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 14:29:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Save recipient address in the "to" field of a notification

Browse Source 
When a precompiled letter is sent via the admin app, we now pass in the address which can be set in the Notifications.to field.
Once a precompiled letters sent by the API has passed validation we can set the address in Notifications.to field.

The celery tasks to validate precompiled letters sent by the API will be done in another PR.
This commit is contained in:
Rebecca Law
2020-01-02 16:35:18 +00:00
parent 5ebd9a473c
commit bb2b514e12
6 changed files with 29 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/app/service/test_rest.py
View File

@@ -2282,7 +2282,8 @@ def test_create_pdf_letter(mocker, sample_service_full_permissions, client, fake
'filename': 'valid.pdf',
'created_by': str(user.id),
'file_id': fake_uuid,
'postage': 'second'
'postage': 'second',
'recipient_address': 'Bugs%20Bunny%0A123%20Main%20Street%0ALooney%20Town'
})
response = client.post(
@@ -2303,11 +2304,13 @@ def test_create_pdf_letter(mocker, sample_service_full_permissions, client, fake
{'error': 'ValidationError', 'message': 'postage is a required property'},
{'error': 'ValidationError', 'message': 'filename is a required property'},
{'error': 'ValidationError', 'message': 'created_by is a required property'},
{'error': 'ValidationError', 'message': 'file_id is a required property'}
{'error': 'ValidationError', 'message': 'file_id is a required property'},
{'error': 'ValidationError', 'message': 'recipient_address is a required property'}
]
),
(
{"postage": "third", "filename": "string", "created_by": "string", "file_id": "string"},
{"postage": "third", "filename": "string", "created_by": "string", "file_id": "string",
"recipient_address": "Some Address"},
[
{'error': 'ValidationError', 'message': 'postage invalid. It must be either first or second.'}
]