From 4a5d4c75d23776483540990033715e1a994e0fbd Mon Sep 17 00:00:00 2001
From: poveyd <32199157+poveyd@users.noreply.github.com>
Date: Tue, 5 May 2020 11:36:43 +0100
Subject: [PATCH] Import from other file and make a few other changes (reorder
 sequence, add sanity check)

---
 .../cycle_notification_history.sql            | 35 +++++++++++++++----
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/database_maintenance/cycle_notification_history.sql b/database_maintenance/cycle_notification_history.sql
index 63561a53a..50b195e71 100644
--- a/database_maintenance/cycle_notification_history.sql
+++ b/database_maintenance/cycle_notification_history.sql
@@ -1,3 +1,5 @@
+-- Stage 1 - manual process
+
 -- Create new notification_history table and primary key.
 CREATE TABLE notification_history_pivot AS SELECT * FROM notification_history WHERE 1=2;
 ALTER TABLE notification_history_pivot ADD PRIMARY KEY (id);
@@ -24,13 +26,27 @@ CREATE TRIGGER update_pivot AFTER UPDATE OF notification_status, billable_units,
 FOR EACH ROW
   EXECUTE PROCEDURE update_pivot_table();
 
-Create foreign key constraints in notification_history_pivot using same names as used in notification_history
+-- Create foreign key constraints in notification_history_pivot using same names as used in notification_history
+ALTER TABLE notification_history_pivot ADD CONSTRAINT fk_notification_history_notification_status FOREIGN KEY (notification_status) REFERENCES notification_status_types(name)
+ALTER TABLE notification_history_pivot ADD CONSTRAINT notification_history_api_key_id_fkey FOREIGN KEY (api_key_id) REFERENCES api_keys(id)
+ALTER TABLE notification_history_pivot ADD CONSTRAINT notification_history_job_id_fkey FOREIGN KEY (job_id) REFERENCES jobs(id)
+ALTER TABLE notification_history_pivot ADD CONSTRAINT notification_history_key_type_fkey FOREIGN KEY (key_type) REFERENCES key_types(name)
+ALTER TABLE notification_history_pivot ADD CONSTRAINT notification_history_service_id_fkey FOREIGN KEY (service_id) REFERENCES services(id)
+ALTER TABLE notification_history_pivot ADD CONSTRAINT notification_history_templates_history_fkey FOREIGN KEY (template_id, template_version) REFERENCES templates_history(id, version)
 
-insert data into notification_history_pivot in batches
+-- Stage 2 - automated process
 
-create remaining indices on notification_history_pivot
+-- insert data into notification_history_pivot in batches
+-- This is handled by a python process
+
+-- Once the Python process has completed, then,
+
+-- Stage 3 - manual process
 
 -- Run basic sanity checks on data in notification_history_pivot, ensuring same number of entries present in notification_history and notification_history_pivot
+SELECT COUNT(*) FROM notification_history_pivot;
+SELECT COUNT(*) FROM notification_history;
+-- Ensure these counts match.
 
 ALTER TABLE notification_history RENAME TO notification_history_old;
 ALTER TABLE notification_history_pivot RENAME TO notification_history;
@@ -40,12 +56,19 @@ ALTER TABLE notification_history_pivot RENAME TO notification_history;
 -- If not then reconcile entries and add remaining entries to notification_history
 
 -- When sure data in new notification_history table are ok:
-ALTER TABLE notification_history_old DROP CONSTRAINT notification_history_pkey; -- May not need this step.
+-- ALTER TABLE notification_history_old DROP CONSTRAINT notification_history_pkey; -- May not need this step.
 DROP TABLE notification_history_old;
 
--- Must rename primary key on new notification_history table or will get issues running this script in the future.
--- This is not very nice.
+-- Could rename primary key on new notification_history table.
 ALTER TABLE notification_history DROP CONSTRAINT notification_history_pivot_pkey;
 ALTER TABLE notification_history ADD PRIMARY KEY (id); -- Will create a new primary key named "notification_history_pkey".
 
+-- Create remaining indices on notification_history_pivot
+--- Create indexes after drop table since the names need to be unique
+--- Or rename these indexes (index names have to be unique in db)
+CREATE INDEX CONCURRENTLY ix_notification_history_job_id ON notification_history_pivot (job_id);
+CREATE INDEX CONCURRENTLY ix_notification_history_reference ON notification_history_pivot (reference);
+CREATE INDEX CONCURRENTLY ix_notification_history_template_id ON notification_history_pivot (template_id);
+CREATE INDEX CONCURRENTLY ix_notifications_service_id_composite ON notification_history_pivot (service_id, key_type, notification_type, created_at);
+
 -- Note that the only impact of these changes