darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

look in correct bucket for letters sent after 5:30pm

Browse Source 
use the same function that we use when uploading, to ensure
consistency (that fn is also well tested already)
This commit is contained in:
Leo Hemsted
2018-11-27 12:21:41 +00:00
parent 6d8534a8fb
commit ba9a774e74
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/letters/utils.py
View File

@@ -57,7 +57,7 @@ def get_bucket_name_and_prefix_for_notification(notification):
bucket_name = current_app.config['TEST_LETTERS_BUCKET_NAME'] bucket_name = current_app.config['TEST_LETTERS_BUCKET_NAME']
else: else:
bucket_name = current_app.config['LETTERS_PDF_BUCKET_NAME'] bucket_name = current_app.config['LETTERS_PDF_BUCKET_NAME']
folder = '{}/'.format(notification.created_at.date()) folder = get_folder_name(notification.created_at, False)
upload_file_name = PRECOMPILED_BUCKET_PREFIX.format( upload_file_name = PRECOMPILED_BUCKET_PREFIX.format(
folder=folder, folder=folder,

9
tests/app/letters/test_letter_utils.py
View File

@@ -35,13 +35,18 @@ def _sample_precompiled_letter_notification_using_test_key(sample_precompiled_le
return sample_precompiled_letter_notification return sample_precompiled_letter_notification
def test_get_bucket_name_and_prefix_for_notification_valid_notification(sample_notification): @pytest.mark.parametrize('created_at,folder', [
(datetime(2017, 1, 1, 17, 29), '2017-01-01'),
(datetime(2017, 1, 1, 17, 31), '2017-01-02'),
])
def test_get_bucket_name_and_prefix_for_notification_valid_notification(sample_notification, created_at, folder):
sample_notification.created_at = created_at
bucket, bucket_prefix = get_bucket_name_and_prefix_for_notification(sample_notification) bucket, bucket_prefix = get_bucket_name_and_prefix_for_notification(sample_notification)
assert bucket == current_app.config['LETTERS_PDF_BUCKET_NAME'] assert bucket == current_app.config['LETTERS_PDF_BUCKET_NAME']
assert bucket_prefix == '{folder}/NOTIFY.{reference}'.format( assert bucket_prefix == '{folder}/NOTIFY.{reference}'.format(
folder=sample_notification.created_at.date(), folder=folder,
reference=sample_notification.reference reference=sample_notification.reference
).upper() ).upper()