darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

allow platform admins to approve their own messages

Browse Source 
makes development a lot easier. we should remove this when we go live
This commit is contained in:
Leo Hemsted
2020-07-15 17:31:59 +01:00
parent 0c870e8dcd
commit b8e6689f62
2 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/app/broadcast_message/test_rest.py
View File

@@ -326,3 +326,30 @@ def test_update_broadcast_message_status_rejects_approval_from_creator(
assert mock_task.called is False
assert f'cannot approve their own broadcast' in response['message']
def test_update_broadcast_message_status_allows_platform_admin_to_approve_own_message(
notify_db,
admin_request,
sample_service,
mocker
):
user = sample_service.created_by
user.platform_admin = True
t = create_template(sample_service, BROADCAST_TYPE)
bm = create_broadcast_message(t, status=BroadcastStatusType.PENDING_APPROVAL)
mock_task = mocker.patch('app.celery.broadcast_message_tasks.send_broadcast_message.apply_async')
response = admin_request.post(
'broadcast_message.update_broadcast_message_status',
_data={'status': BroadcastStatusType.BROADCASTING, 'created_by': str(user.id)},
service_id=t.service_id,
broadcast_message_id=bm.id,
_expected_status=200
)
assert response['status'] == BroadcastStatusType.BROADCASTING
assert response['approved_at'] is not None
assert response['created_by_id'] == str(user.id)
assert response['approved_by_id'] == str(user.id)
mock_task.assert_called_once_with(kwargs={'broadcast_message_id': str(bm.id)}, queue='notify-internal-tasks')