darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

allow platform admins to approve their own messages

Browse Source 
makes development a lot easier. we should remove this when we go live
This commit is contained in:
Leo Hemsted
2020-07-15 17:31:59 +01:00
parent 0c870e8dcd
commit b8e6689f62
2 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/broadcast_message/rest.py
View File

@@ -41,8 +41,15 @@ def _update_broadcast_message(broadcast_message, new_status, updating_user):
# TODO: Restrict status transitions
# TODO: validate that the user belongs to the same service, isn't the creator, has permissions, etc
if new_status == BroadcastStatusType.BROADCASTING:
broadcast_message.approved_at = datetime.utcnow()
broadcast_message.approved_by = updating_user
# TODO: Remove this platform admin shortcut when the feature goes live
if updating_user == broadcast_message.created_by and not updating_user.platform_admin:
abort(
400,
f'User {updating_user.id} cannot approve their own broadcast {broadcast_message.id}'
)
else:
broadcast_message.approved_at = datetime.utcnow()
broadcast_message.approved_by = updating_user
if new_status == BroadcastStatusType.CANCELLED:
broadcast_message.cancelled_at = datetime.utcnow()