Updates after review

- Modified the services_dao to return an int instead of a datetime to
make usage easier and removed the BST function on year as it is not
relevant for year
- Improved tests do there is less logic by ordering the result so there
is less reliance on the template id
- Renamed variable in stats_template_usage_by_month_dao.py to make it
consistent with the method
This commit is contained in:
Richard Chapman
2017-11-09 14:13:42 +00:00
parent 59df6bdbb6
commit b78d989d4e
14 changed files with 76 additions and 148 deletions

View File

@@ -410,13 +410,13 @@ def check_job_status():
@notify_celery.task(name='daily-stats-template_usage_by_month')
@statsd(namespace="tasks")
def daily_stats_template_usage_my_month():
def daily_stats_template_usage_by_month():
results = dao_fetch_monthly_historical_stats_by_template()
for result in results:
insert_or_update_stats_for_template(
result.template_id,
result.month.month,
result.year.year,
result.month,
result.year,
result.count
)