darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #402 from GSA/notify-api-387

Browse Source 
notify-api-387 Scan projects for unused code
This commit is contained in:
Steven Reilly
2023-08-14 13:52:38 -04:00
committed by GitHub
parent d955ede5c3 8d74a46d7c
commit b731dd5abe
5 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/__init__.py
View File

@@ -357,17 +357,17 @@ def setup_sqlalchemy_events(app):
# need this or db.engine isn't accessible
with app.app_context():
@event.listens_for(db.engine, 'connect')
def connect(dbapi_connection, connection_record):
def connect(dbapi_connection, connection_record): # noqa
# connection first opened with db
TOTAL_DB_CONNECTIONS.inc()
@event.listens_for(db.engine, 'close')
def close(dbapi_connection, connection_record):
def close(dbapi_connection, connection_record): # noqa
# connection closed (probably only happens with overflow connections)
TOTAL_DB_CONNECTIONS.dec()
@event.listens_for(db.engine, 'checkout')
def checkout(dbapi_connection, connection_record, connection_proxy):
def checkout(dbapi_connection, connection_record, connection_proxy): # noqa
try:
# connection given to a web worker
TOTAL_CHECKED_OUT_DB_CONNECTIONS.inc()
@@ -405,7 +405,7 @@ def setup_sqlalchemy_events(app):
current_app.logger.exception("Exception caught for checkout event.")
@event.listens_for(db.engine, 'checkin')
def checkin(dbapi_connection, connection_record):
def checkin(dbapi_connection, connection_record): # noqa
try:
# connection returned by a web worker
TOTAL_CHECKED_OUT_DB_CONNECTIONS.dec()

5
app/commands.py
View File

@@ -572,8 +572,9 @@ def populate_annual_billing_with_defaults(year, missing_services_only):
print(f'update service {service.id} with default')
set_default_free_allowance_for_service(service, year)
def validate_mobile(ctx, param, value):
# We use noqa to protect this method from the vulture dead code check. Otherwise, the params ctx and param
# will trigger vulture and cause a build failure.
def validate_mobile(ctx, param, value): # noqa
if (len(''.join(i for i in value if i.isdigit())) != 10):
raise click.BadParameter("mobile number must have 10 digits")
else: