darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Commented out tests in progress

Browse Source
This commit is contained in:
Martyn Inglis
2016-06-07 12:54:25 +01:00
parent 92e4c0872b
commit b6fa6815ee
1 changed files with 80 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

160
tests/app/celery/test_provider_tasks.py
View File

@@ -140,86 +140,86 @@ def test_should_send_template_to_correct_sms_provider_and_persist(
content="Sample service: This is a template", content="Sample service: This is a template",
reference=str(db_notification.id) reference=str(db_notification.id)
) )
#
### FIXME # ### FIXME
def test_send_sms_should_use_template_version_from_job_not_latest(sample_template, mocker): # def test_send_sms_should_use_template_version_from_job_not_latest(sample_template, mocker):
notification = _notification_json(sample_template, '+447234123123') # notification = _notification_json(sample_template, '+447234123123')
mocker.patch('app.encryption.decrypt', return_value=notification) # mocker.patch('app.encryption.decrypt', return_value=notification)
mocker.patch('app.mmg_client.send_sms') # mocker.patch('app.mmg_client.send_sms')
mocker.patch('app.mmg_client.get_name', return_value="mmg") # mocker.patch('app.mmg_client.get_name', return_value="mmg")
version_on_notification = sample_template.version # version_on_notification = sample_template.version
#
# Change the template # # Change the template
from app.dao.templates_dao import dao_update_template, dao_get_template_by_id # from app.dao.templates_dao import dao_update_template, dao_get_template_by_id
sample_template.content = sample_template.content + " another version of the template" # sample_template.content = sample_template.content + " another version of the template"
dao_update_template(sample_template) # dao_update_template(sample_template)
t = dao_get_template_by_id(sample_template.id) # t = dao_get_template_by_id(sample_template.id)
assert t.version > version_on_notification # assert t.version > version_on_notification
#
notification_id = uuid.uuid4() # notification_id = uuid.uuid4()
now = datetime.utcnow() # now = datetime.utcnow()
send_sms( # send_sms(
sample_template.service_id, # sample_template.service_id,
notification_id, # notification_id,
"encrypted-in-reality", # "encrypted-in-reality",
now.strftime(DATETIME_FORMAT) # now.strftime(DATETIME_FORMAT)
) # )
#
mmg_client.send_sms.assert_called_once_with( # mmg_client.send_sms.assert_called_once_with(
to=format_phone_number(validate_phone_number("+447234123123")), # to=format_phone_number(validate_phone_number("+447234123123")),
content="Sample service: This is a template", # content="Sample service: This is a template",
reference=str(notification_id) # reference=str(notification_id)
) # )
#
persisted_notification = notifications_dao.get_notification(sample_template.service_id, notification_id) # persisted_notification = notifications_dao.get_notification(sample_template.service_id, notification_id)
assert persisted_notification.id == notification_id # assert persisted_notification.id == notification_id
assert persisted_notification.to == '+447234123123' # assert persisted_notification.to == '+447234123123'
assert persisted_notification.template_id == sample_template.id # assert persisted_notification.template_id == sample_template.id
assert persisted_notification.template_version == version_on_notification # assert persisted_notification.template_version == version_on_notification
assert persisted_notification.template_version != sample_template.version # assert persisted_notification.template_version != sample_template.version
assert persisted_notification.created_at == now # assert persisted_notification.created_at == now
assert persisted_notification.sent_at > now # assert persisted_notification.sent_at > now
assert persisted_notification.status == 'sending' # assert persisted_notification.status == 'sending'
assert persisted_notification.sent_by == 'mmg' # assert persisted_notification.sent_by == 'mmg'
assert persisted_notification.content_char_count == len("Sample service: This is a template") # assert persisted_notification.content_char_count == len("Sample service: This is a template")
#
#
### FIXME # ### FIXME
def test_should_call_send_sms_response_task_if_research_mode(notify_db, sample_service, sample_template, mocker): # def test_should_call_send_sms_response_task_if_research_mode(notify_db, sample_service, sample_template, mocker):
notification = _notification_json( # notification = _notification_json(
sample_template, # sample_template,
to="+447234123123" # to="+447234123123"
) # )
mocker.patch('app.encryption.decrypt', return_value=notification) # mocker.patch('app.encryption.decrypt', return_value=notification)
mocker.patch('app.mmg_client.send_sms') # mocker.patch('app.mmg_client.send_sms')
mocker.patch('app.mmg_client.get_name', return_value="mmg") # mocker.patch('app.mmg_client.get_name', return_value="mmg")
mocker.patch('app.celery.research_mode_tasks.send_sms_response.apply_async') # mocker.patch('app.celery.research_mode_tasks.send_sms_response.apply_async')
#
sample_service.research_mode = True # sample_service.research_mode = True
notify_db.session.add(sample_service) # notify_db.session.add(sample_service)
notify_db.session.commit() # notify_db.session.commit()
#
notification_id = uuid.uuid4() # notification_id = uuid.uuid4()
now = datetime.utcnow() # now = datetime.utcnow()
send_sms( # send_sms(
sample_service.id, # sample_service.id,
notification_id, # notification_id,
"encrypted-in-reality", # "encrypted-in-reality",
now.strftime(DATETIME_FORMAT) # now.strftime(DATETIME_FORMAT)
) # )
assert not mmg_client.send_sms.called # assert not mmg_client.send_sms.called
send_sms_response.apply_async.assert_called_once_with( # send_sms_response.apply_async.assert_called_once_with(
('mmg', str(notification_id), "+447234123123"), queue='research-mode' # ('mmg', str(notification_id), "+447234123123"), queue='research-mode'
) # )
#
persisted_notification = notifications_dao.get_notification(sample_service.id, notification_id) # persisted_notification = notifications_dao.get_notification(sample_service.id, notification_id)
assert persisted_notification.id == notification_id # assert persisted_notification.id == notification_id
assert persisted_notification.to == '+447234123123' # assert persisted_notification.to == '+447234123123'
assert persisted_notification.template_id == sample_template.id # assert persisted_notification.template_id == sample_template.id
assert persisted_notification.status == 'sending' # assert persisted_notification.status == 'sending'
assert persisted_notification.sent_at > now # assert persisted_notification.sent_at > now
assert persisted_notification.created_at == now # assert persisted_notification.created_at == now
assert persisted_notification.sent_by == 'mmg' # assert persisted_notification.sent_by == 'mmg'
def _notification_json(template, to, personalisation=None, job_id=None, row_number=None): def _notification_json(template, to, personalisation=None, job_id=None, row_number=None):