darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 00:06:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #400 from alphagov/remove-task-send-sms-code

Browse Source 
Remove task send_sms_code.
This commit is contained in:
Rebecca Law
2016-06-13 11:34:26 +01:00
committed by GitHub
parent 59497fde17 50ec2eb7fc
commit b677768de1
2 changed files with 0 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/celery/tasks.py
View File

@@ -375,20 +375,6 @@ def send_email(service_id, notification_id, from_address, encrypted_notification
current_app.logger.exception(e) current_app.logger.exception(e)
@notify_celery.task(name='send-sms-code')
def send_sms_code(encrypted_verification):
provider = provider_to_use('sms', 'send-sms-code')
verification_message = encryption.decrypt(encrypted_verification)
try:
provider.send_sms(validate_and_format_phone_number(verification_message['to']),
"{} is your Notify authentication code".format(
verification_message['secret_code']),
'send-sms-code')
except SmsClientException as e:
current_app.logger.exception(e)
# TODO: when placeholders in templates work, this will be a real template # TODO: when placeholders in templates work, this will be a real template
def invitation_template(user_name, service_name, url, expiry_date): def invitation_template(user_name, service_name, url, expiry_date):
from string import Template from string import Template

28
tests/app/celery/test_tasks.py
View File

@@ -6,7 +6,6 @@ from notifications_utils.recipients import validate_phone_number, format_phone_n
from app.celery.tasks import ( from app.celery.tasks import (
send_sms, send_sms,
send_sms_code,
send_email, send_email,
process_job, process_job,
email_invited_user, email_invited_user,
@@ -898,33 +897,6 @@ def test_should_not_send_email_if_db_peristance_failed(sample_email_template, mo
assert 'No row was found for one' in str(e.value) assert 'No row was found for one' in str(e.value)
def test_should_send_sms_code(mocker):
notification = {'to': '+447234123123',
'secret_code': '12345'}
encrypted_notification = encryption.encrypt(notification)
mocker.patch('app.mmg_client.send_sms')
send_sms_code(encrypted_notification)
mmg_client.send_sms.assert_called_once_with(
format_phone_number(validate_phone_number(notification['to'])),
"{} is your Notify authentication code".format(notification['secret_code']),
'send-sms-code')
def test_should_throw_mmg_client_exception(mocker):
notification = {'to': '+447234123123',
'secret_code': '12345'}
encrypted_notification = encryption.encrypt(notification)
mocker.patch('app.mmg_client.send_sms', side_effect=MMGClientException(mmg_error))
send_sms_code(encrypted_notification)
mmg_client.send_sms.assert_called_once_with(
format_phone_number(validate_phone_number(notification['to'])),
"{} is your Notify authentication code".format(notification['secret_code']),
'send-sms-code')
def test_email_invited_user_should_send_email(notify_api, mocker): def test_email_invited_user_should_send_email(notify_api, mocker):
with notify_api.test_request_context(): with notify_api.test_request_context():
invitation = {'to': 'new_person@it.gov.uk', invitation = {'to': 'new_person@it.gov.uk',