darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 14:08:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

more tests

Browse Source
This commit is contained in:
Kenneth Kehl
2025-07-02 11:56:11 -07:00
parent b0c910ee6f
commit b5fdc76a4e
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.ds.baseline
View File

@@ -331,7 +331,7 @@
"filename": "tests/app/user/test_rest.py", "filename": "tests/app/user/test_rest.py",
"hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8", "hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
"is_verified": false, "is_verified": false,
"line_number": 111, "line_number": 110,
"is_secret": false "is_secret": false
}, },
{ {
@@ -339,7 +339,7 @@
"filename": "tests/app/user/test_rest.py", "filename": "tests/app/user/test_rest.py",
"hashed_secret": "0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33", "hashed_secret": "0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33",
"is_verified": false, "is_verified": false,
"line_number": 875, "line_number": 874,
"is_secret": false "is_secret": false
} }
], ],
@@ -374,5 +374,5 @@
} }
] ]
}, },
"generated_at": "2025-07-02T17:46:10Z" "generated_at": "2025-07-02T18:56:01Z"
} }

2
Makefile
View File

@@ -105,7 +105,7 @@ test: ## Run tests and create coverage report
poetry run coverage run --omit=*/migrations/*,*/tests/* -m pytest --maxfail=10 poetry run coverage run --omit=*/migrations/*,*/tests/* -m pytest --maxfail=10
## TODO set this back to 95 asap ## TODO set this back to 95 asap
poetry run coverage report -m --fail-under=93 poetry run coverage report -m --fail-under=94
poetry run coverage html -d .coverage_cache poetry run coverage html -d .coverage_cache
.PHONY: test-debug .PHONY: test-debug

2
app/celery/tasks.py
View File

@@ -167,7 +167,7 @@ def process_row(row, template, job, service, sender_id=None):
# Assuming the limit is annual, is it calendar year, fiscal year, MOU year? # Assuming the limit is annual, is it calendar year, fiscal year, MOU year?
# Do we need a command to run to clear the redis value, or should it happen automatically? # Do we need a command to run to clear the redis value, or should it happen automatically?
def __total_sending_limits_for_job_exceeded(service, job, job_id): def __total_sending_limits_for_job_exceeded(service, job, job_id):
print(hilite("ENTER __total_sending_limits_for_job_exceeded"))
try: try:
total_sent = check_service_over_total_message_limit(KeyType.NORMAL, service) total_sent = check_service_over_total_message_limit(KeyType.NORMAL, service)
if total_sent + job.notification_count > service.total_message_limit: if total_sent + job.notification_count > service.total_message_limit:

4
tests/app/notifications/test_receive_notification.py
View File

@@ -449,4 +449,6 @@ def test_receive_sns_sms_success(client, app):
date_received="2025-07-01T10:00:00:000Z", date_received="2025-07-01T10:00:00:000Z",
provider_name="sns", provider_name="sns",
) )
mock_task.assert_called_once_with(["inbound-id", "service-id"], queue="notify-internal-tasks") mock_task.assert_called_once_with(
["inbound-id", "service-id"], queue="notify-internal-tasks"
)

2
tests/app/user/test_rest.py
View File

@@ -12,7 +12,6 @@ from app import db
from app.dao.service_user_dao import dao_get_service_user, dao_update_service_user from app.dao.service_user_dao import dao_get_service_user, dao_update_service_user
from app.enums import AuthType, KeyType, NotificationType, PermissionType from app.enums import AuthType, KeyType, NotificationType, PermissionType
from app.models import Notification, Permission, User from app.models import Notification, Permission, User
from app.utils import hilite
from tests.app.db import ( from tests.app.db import (
create_organization, create_organization,
create_service, create_service,
@@ -1076,7 +1075,6 @@ def test_get_user_login_gov_user(notify_db_session, admin_request):
_data=data, _data=data,
) )
print(hilite(users["data"]))
assert users["data"]["email_address"] == "findel.mestro@foo.com" assert users["data"]["email_address"] == "findel.mestro@foo.com"