From b464894325338cd3d58fcbe298add68470ac7d5c Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Thu, 18 Feb 2021 12:54:22 +0000 Subject: [PATCH] update to check for instance of SerialisedService --- app/delivery/send_to_providers.py | 2 +- tests/app/delivery/test_send_to_providers.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/delivery/send_to_providers.py b/app/delivery/send_to_providers.py index b5390cc1b..1900fc250 100644 --- a/app/delivery/send_to_providers.py +++ b/app/delivery/send_to_providers.py @@ -196,7 +196,7 @@ def get_html_email_options(service): 'govuk_banner': True, 'brand_banner': False, } - if isinstance(service.email_branding, str): + if isinstance(service, SerialisedService): branding = dao_get_email_branding_by_id(service.email_branding) else: branding = service.email_branding diff --git a/tests/app/delivery/test_send_to_providers.py b/tests/app/delivery/test_send_to_providers.py index 64ba6ea14..1cad72af3 100644 --- a/tests/app/delivery/test_send_to_providers.py +++ b/tests/app/delivery/test_send_to_providers.py @@ -756,9 +756,8 @@ def test_send_email_to_provider_should_user_normalised_to( notification = create_notification(template=sample_email_template, to_field='TEST@example.com', normalised_to='test@example.com') - print("************* start") + send_to_providers.send_email_to_provider(notification) - print("End ******************") send_mock.assert_called_once_with(ANY, notification.normalised_to, ANY,