From b2d98f7bd315494ddf0dfe67beeab2c0a09429ed Mon Sep 17 00:00:00 2001
From: Kenneth Kehl <@kkehl@flexion.us>
Date: Fri, 27 Jun 2025 10:37:23 -0700
Subject: [PATCH] increase code coverage

---
 tests/app/aws/test_s3.py | 69 ++++++++++++++++++++++++++--------------
 1 file changed, 46 insertions(+), 23 deletions(-)

diff --git a/tests/app/aws/test_s3.py b/tests/app/aws/test_s3.py
index 8d5e4eec3..c5ae43660 100644
--- a/tests/app/aws/test_s3.py
+++ b/tests/app/aws/test_s3.py
@@ -607,32 +607,55 @@ def test_get_s3_client_default_credentials():
     with patch.dict(os.environ, {}, clear=True):
         client = get_s3_client()
         assert client is not None, "Client should be created with default credentials"
-        assert client.client_config.region_name, "Client should have a region"
+        assert client._client_config.region_name, "Client should have a region"
 
 
-def test_get_s3_client_invalid_credentials():
-    with patch.dict(
+# def test_get_s3_client_invalid_credentials():
+#     with patch.dict(
+#         os.environ,
+#         {
+#             "AWS_ACCESS_KEY_ID": "invalid-key",
+#             "AWS_SECRET_ACCESS_KEY": "invalid-secret",  # pragma: allowlist secret
+#             "AWS_DEFAULT_REGION": "us-north-1",
+#         },
+#     ):
+#         with patch(
+#             "boto3.client",
+#             side_effect=botocore.exceptions.ClientError(
+#                 {
+#                     "Error": {
+#                         "Code": "InvalidClientTokenId",
+#                         "Message": "Invalid credentials",
+#                     }
+#                 },
+#                 "HeadBucket",
+#             ),
+#         ):
+#             try:
+#                 get_s3_client()
+#                 assert 1 == 0, "Should raise ClientError for invalid credentials"
+#             except botocore.exceptions.ClientError as e:
+#                 assert e.response["Error"]["Code"] == "InvalidClientTokenId"
+
+
+def test_get_s3_client_no_region():
+    with patch.ditc(
         os.environ,
         {
-            "AWS_ACCESS_KEY_ID": "invalid-key",
-            "AWS_SECRET_ACCESS_KEY": "invalid-secret",  # pragma: allowlist secret
-            "AWS_DEFAULT_REGION": "us-north-1",
+            "AWS_ACCESS_KEY_ID": "test-key",
+            "AWS_SECRET_ACCESS_KEY": "test-secret",  # pragma: allowlist secret
         },
+        clear=True,
     ):
-        with patch(
-            "boto3.client",
-            side_effect=botocore.exceptions.ClientError(
-                {
-                    "Error": {
-                        "Code": "InvalidClientTokenId",
-                        "Message": "Invalid credentials",
-                    }
-                },
-                "HeadBucket",
-            ),
-        ):
-            try:
-                get_s3_client()
-                assert 1 == 0, "Should raise ClientError for invalid credentials"
-            except botocore.exceptions.ClientError as e:
-                assert e.response["Error"]["Code"] == "InvalidClientTokenId"
+        with patch("boto3.client") as mock_client:
+            mock_client.return_value = MagicMock(
+                _client_config=MagicMock(region_name="us-north-1")
+            )
+            client = get_s3_client()
+            assert client is not None
+            mock_client.assert_called_with(
+                "s3",
+                aws_access_key_id="test-key",
+                aws_secret_access_key="test-secret",  # pragma: allowlist secret
+                region_name="us-north-1",
+            )