darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-04 12:38:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

dont load template contents for job page

Browse Source 
rename the notification_status_schema to make it apparent that it
involves the template, and then don't use it on the job page - the
job page doesn't do anything with the data. won't somebody think of
the cpu cycles! (also means it ignores problems with template
versions)
This commit is contained in:
Leo Hemsted
2016-07-26 12:34:39 +01:00
parent 95af32f289
commit b28e7efd14
6 changed files with 23 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/schemas.py
View File

@@ -144,7 +144,7 @@ class NotificationModelSchema(BaseSchema):
class Meta:
model = models.Notification
strict = True
exclude = ("_personalisation",)
exclude = ('_personalisation', 'job', 'service', 'template', 'api_key', '')
class BaseTemplateSchema(BaseSchema):
@@ -280,7 +280,7 @@ class SmsAdminNotificationSchema(SmsNotificationSchema):
content = fields.Str(required=True)
class NotificationStatusSchema(BaseSchema):
class NotificationWithTemplateSchema(BaseSchema):
template = fields.Nested(TemplateSchema, only=["id", "name", "template_type", "content", "subject"], dump_only=True)
job = fields.Nested(JobSchema, only=["id", "original_file_name"], dump_only=True)
@@ -516,8 +516,9 @@ sms_template_notification_schema = SmsTemplateNotificationSchema()
job_sms_template_notification_schema = JobSmsTemplateNotificationSchema()
email_notification_schema = EmailNotificationSchema()
job_email_template_notification_schema = JobEmailTemplateNotificationSchema()
notification_status_schema = NotificationStatusSchema()
notification_status_schema_load_json = NotificationStatusSchema(load_json=True)
notification_schema = NotificationModelSchema()
notification_with_template_schema = NotificationWithTemplateSchema()
notification_with_template_schema_load_json = NotificationWithTemplateSchema(load_json=True)
invited_user_schema = InvitedUserSchema()
permission_schema = PermissionSchema()
email_data_request_schema = EmailDataSchema()