darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-23 07:46:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixing up a couple of pull request comments

Browse Source 
- python style if
- renamed the relationships
This commit is contained in:
Martyn Inglis
2016-05-11 15:36:17 +01:00
parent 668f311a1a
commit b22c52131d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/tasks.py
View File

@@ -467,7 +467,7 @@ def provider_to_use(notification_type, notification_id):
provider for provider in get_provider_details_by_notification_type(notification_type) if provider.active provider for provider in get_provider_details_by_notification_type(notification_type) if provider.active
] ]
if len(active_providers_in_order) == 0: if not active_providers_in_order:
current_app.logger.error( current_app.logger.error(
"{} {} failed as no active providers".format(notification_type, notification_id) "{} {} failed as no active providers".format(notification_type, notification_id)
) )

4
app/models.py
View File

@@ -200,7 +200,7 @@ class ProviderStatistics(db.Model):
id = db.Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4) id = db.Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4)
day = db.Column(db.Date, nullable=False) day = db.Column(db.Date, nullable=False)
provider_id = db.Column(UUID(as_uuid=True), db.ForeignKey('provider_details.id'), index=True, nullable=False) provider_id = db.Column(UUID(as_uuid=True), db.ForeignKey('provider_details.id'), index=True, nullable=False)
provider_stats_to_provider = db.relationship( provider = db.relationship(
'ProviderDetails', backref=db.backref('provider_stats', lazy='dynamic') 'ProviderDetails', backref=db.backref('provider_stats', lazy='dynamic')
) )
service_id = db.Column(UUID(as_uuid=True), db.ForeignKey('services.id'), index=True, nullable=False) service_id = db.Column(UUID(as_uuid=True), db.ForeignKey('services.id'), index=True, nullable=False)
@@ -215,7 +215,7 @@ class ProviderRates(db.Model):
valid_from = db.Column(db.DateTime, nullable=False) valid_from = db.Column(db.DateTime, nullable=False)
rate = db.Column(db.Numeric(), nullable=False) rate = db.Column(db.Numeric(), nullable=False)
provider_id = db.Column(UUID(as_uuid=True), db.ForeignKey('provider_details.id'), index=True, nullable=False) provider_id = db.Column(UUID(as_uuid=True), db.ForeignKey('provider_details.id'), index=True, nullable=False)
provider_rate_to_provider = db.relationship('ProviderDetails', backref=db.backref('provider_rates', lazy='dynamic')) provider = db.relationship('ProviderDetails', backref=db.backref('provider_rates', lazy='dynamic'))
class ProviderDetails(db.Model): class ProviderDetails(db.Model):