darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 14:31:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

First batch of flake8 changes.

Browse Source 
Many unused variables, and replacing some old fixtures with
admin_request before I realised just how many there where 😩
This commit is contained in:
Leo Hemsted
2017-11-28 17:00:01 +00:00
parent 363105774f
commit b1cccdcc6b
9 changed files with 84 additions and 202 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/app/v2/notifications/test_get_notifications.py
View File

@@ -7,7 +7,7 @@ from tests import create_authorization_header
from tests.app.db import (
create_notification,
create_template,
create_service)
)
from tests.app.conftest import (
sample_notification,
@@ -30,7 +30,8 @@ def test_get_notification_by_id_returns_200(
scheduled_for="2017-05-12 15:15"
)
another = create_notification(
# another
create_notification(
template=sample_template,
billable_units=billable_units,
sent_by=provider,

16
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -634,7 +634,7 @@ def test_post_email_notification_with_valid_reply_to_id_returns_201(client, samp
def test_post_email_notification_with_invalid_reply_to_id_returns_400(client, sample_email_template, mocker, fake_uuid):
mocked = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
data = {
"email_address": sample_email_template.service.users[0].email_address,
"template_id": sample_email_template.id,
@@ -652,10 +652,9 @@ def test_post_email_notification_with_invalid_reply_to_id_returns_400(client, sa
assert 'BadRequestError' in resp_json['errors'][0]['error']
def test_persist_sender_to_notification_mapping_for_email(notify_db_session):
service = create_service()
template = create_template(service=service, template_type=EMAIL_TYPE)
sender = create_reply_to_email(service=service, email_address='reply@test.com', is_default=False)
def test_persist_sender_to_notification_mapping_for_email(sample_service):
template = create_template(service=sample_service, template_type=EMAIL_TYPE)
sender = create_reply_to_email(service=sample_service, email_address='reply@test.com', is_default=False)
form = {
"email_address": "recipient@test.com",
"template_id": str(template.id),
@@ -669,10 +668,9 @@ def test_persist_sender_to_notification_mapping_for_email(notify_db_session):
assert notification_to_email_reply_to[0].service_email_reply_to_id == sender.id
def test_persist_sender_to_notification_mapping_for_sms(notify_db_session):
service = create_service()
template = create_template(service=service, template_type=SMS_TYPE)
sender = create_service_sms_sender(service=service, sms_sender='12345', is_default=False)
def test_persist_sender_to_notification_mapping_for_sms(sample_service):
template = create_template(service=sample_service, template_type=SMS_TYPE)
sender = create_service_sms_sender(service=sample_service, sms_sender='12345', is_default=False)
form = {
'phone_number': '+447700900855',
'template_id': str(template.id),