diff --git a/app/schema_validation/__init__.py b/app/schema_validation/__init__.py index 4cb27b12b..88f0e2421 100644 --- a/app/schema_validation/__init__.py +++ b/app/schema_validation/__init__.py @@ -18,7 +18,7 @@ def build_error_message(errors, schema): field = "'{}' {}".format(e.path[0], e.schema.get('validationMessage')) if e.schema.get( 'validationMessage') else e.message s = field.split("'") - field = OrderedDict({"error": "ValidationError", "message": "{}{}".format(s[1], s[2])}) + field = {"error": "ValidationError", "message": "{}{}".format(s[1], s[2])} fields.append(field) message = { "status_code": 400, diff --git a/tests/app/notifications/test_validators.py b/tests/app/notifications/test_validators.py index 2810e75e5..03781bcb8 100644 --- a/tests/app/notifications/test_validators.py +++ b/tests/app/notifications/test_validators.py @@ -48,7 +48,7 @@ def test_check_template_is_for_notification_type_fails_when_template_type_does_n with pytest.raises(BadRequestError) as e: check_template_is_for_notification_type(notification_type=notification_type, template_type=template_type) - e.value.status_code == 400 + assert e.value.status_code == 400 error_message = '{0} template is not suitable for {1} notification'.format(template_type, notification_type) assert e.value.message == error_message assert e.value.fields == [{'template': error_message}]