remove free_sms_fragment_limit from service

* remove from model
* still required when calling POST /service - we just call through
  from dao_create_service to add a new annual billing entry.
* removed from POST /service/<id> update_service - if you want to
  update/add a new one, use POST /service/<id>/free-sms-fragment-limit
* made sure tests create services with default 250k limit.
This commit is contained in:
Leo Hemsted
2017-12-01 16:31:21 +00:00
parent f0ba491d04
commit b0d4044ff5
8 changed files with 58 additions and 125 deletions

View File

@@ -162,13 +162,12 @@ def sample_service(
'message_limit': limit,
'restricted': restricted,
'email_from': email_from,
'created_by': user,
'free_sms_fragment_limit': free_sms_fragment_limit
'created_by': user
}
service = Service.query.filter_by(name=service_name).first()
if not service:
service = Service(**data)
dao_create_service(service, user, service_permissions=permissions)
dao_create_service(service, user, free_sms_fragment_limit, service_permissions=permissions)
if research_mode:
service.research_mode = research_mode
@@ -1002,7 +1001,12 @@ def notify_service(notify_db, notify_db_session):
created_by=user,
prefix_sms=False,
)
dao_create_service(service=service, service_id=current_app.config['NOTIFY_SERVICE_ID'], user=user)
dao_create_service(
service=service,
service_id=current_app.config['NOTIFY_SERVICE_ID'],
user=user,
free_sms_fragment_limit=250000 # live central gov service
)
data = {
'service': service,