From adf81ef6893101afea1236c286442513ea80d5b9 Mon Sep 17 00:00:00 2001
From: Andy Paine <andy.paine@digital.cabinet-office.gov.uk>
Date: Thu, 30 May 2019 11:56:19 +0100
Subject: [PATCH] BAU: Use port health checks for API

- We've been seeing an issue when traffic spikes of the http health
  checks taking over 1s and PaaS killing the app
- Port health checks won't care about being stuck in a queue so should
  continue to work even at high loads
- We have functional tests to catch if a deployment brings up the app
  (and so passes port health check) but then doesn't work
---
 manifest.yml.j2 | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/manifest.yml.j2 b/manifest.yml.j2
index 0da756d85..01dc5db5c 100644
--- a/manifest.yml.j2
+++ b/manifest.yml.j2
@@ -4,7 +4,7 @@
       'staging': ['api.staging-notify.works'],
       'production': ['api.notifications.service.gov.uk'],
     },
-    'healthcheck-endpoint': '/_status?simple=true',
+    'health-check-type': 'port',
   },
   'notify-api-db-migration': {'NOTIFY_APP_NAME': 'api', 'instances': 0},
 
@@ -39,12 +39,7 @@ applications:
       - route: {{ route }}
       {%- endfor%}
       - route: {{ CF_APP }}-{{ environment }}.cloudapps.digital
-    {% if 'healthcheck-endpoint' in app %}
-    health-check-type: http
-    health-check-http-endpoint: {{ app['healthcheck-endpoint'] }}
-    {% else %}
-    health-check-type: process
-    {% endif %}
+    health-check-type: {{ app.get('health-check-type', 'process') }}
 
     services:
       - notify-db