darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Handle and log document-download-api request errors

Browse Source 
Catches the requests exception for document-download-api calls, logs
a warning and returns a matching response code and message.

Connection errors to document download result in 503 response to the
user.
This commit is contained in:
Alexey Bezhan
2018-04-09 16:09:54 +01:00
parent f2e163dc43
commit b097a16a86
3 changed files with 67 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/app/clients/test_document_download.py
View File

@@ -2,7 +2,7 @@ import requests
import requests_mock
import pytest
from app.clients.document_download import DocumentDownloadClient
from app.clients.document_download import DocumentDownloadClient, DocumentDownloadError
@pytest.fixture(scope='function')
@@ -32,6 +32,25 @@ def test_upload_document(document_download):
def test_should_raise_for_status(document_download):
with pytest.raises(requests.HTTPError), requests_mock.Mocker() as request_mock:
request_mock.post('https://document-download/services/service-id/documents', json={}, status_code=403)
with pytest.raises(DocumentDownloadError) as excinfo, requests_mock.Mocker() as request_mock:
request_mock.post('https://document-download/services/service-id/documents', json={
'error': 'Invalid encoding'
}, status_code=403)
document_download.upload_document('service-id', 'abababab')
assert excinfo.value.message == 'Invalid encoding'
assert excinfo.value.status_code == 403
def test_should_raise_for_connection_errors(document_download):
with pytest.raises(DocumentDownloadError) as excinfo, requests_mock.Mocker() as request_mock:
request_mock.post(
'https://document-download/services/service-id/documents',
exc=requests.exceptions.ConnectTimeout
)
document_download.upload_document('service-id', 'abababab')
assert excinfo.value.message == 'connection error'
assert excinfo.value.status_code == 503