darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

don't return or accept reply_to_email in update service anymore

Browse Source 
either
This commit is contained in:
Leo Hemsted
2018-02-22 11:03:35 +00:00
parent 703cee66f0
commit aedbd37d8b
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/schemas.py
View File

@@ -205,21 +205,17 @@ class ServiceSchema(BaseSchema):
email_branding = field_for(models.Service, 'email_branding')
organisation = field_for(models.Service, 'organisation')
override_flag = False
reply_to_email_address = fields.Method(method_name="get_reply_to_email_address")
letter_contact_block = fields.Method(method_name="get_letter_contact")
def service_permissions(self, service):
return [p.permission for p in service.permissions]
def get_reply_to_email_address(self, service):
return service.get_default_reply_to_email_address()
def get_letter_contact(self, service):
return service.get_default_letter_contact()
class Meta:
model = models.Service
dump_only = ['reply_to_email_address', 'letter_contact_block']
dump_only = ['letter_contact_block']
exclude = (
'updated_at',
'created_at',

1
tests/app/service/test_rest.py
View File

@@ -197,7 +197,6 @@ def test_get_service_by_id_and_user(client, sample_service, sample_user):
json_resp = json.loads(resp.get_data(as_text=True))
assert json_resp['data']['name'] == sample_service.name
assert json_resp['data']['id'] == str(sample_service.id)
assert json_resp['data']['reply_to_email_address'] == 'new@service.com'
def test_get_service_by_id_should_404_if_no_service_for_user(notify_api, sample_user):