darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 16:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make Noti and NotiHis status column nullable:

Browse Source 
This is in preparation for deprecating this old column
This commit is contained in:
Imdad Ahad
2017-07-10 11:33:39 +01:00
parent 50dbfec383
commit ae388a3cfc
2 changed files with 57 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models.py
View File

@@ -788,7 +788,7 @@ class Notification(db.Model):
unique=False,
nullable=True,
onupdate=datetime.datetime.utcnow)
_status_enum = db.Column('status', NOTIFICATION_STATUS_TYPES_ENUM, index=True, nullable=False, default='created')
_status_enum = db.Column('status', NOTIFICATION_STATUS_TYPES_ENUM, index=True, nullable=True, default='created')
_status_fkey = db.Column(
'notification_status',
db.String,
@@ -999,7 +999,7 @@ class NotificationHistory(db.Model, HistoryModel):
sent_at = db.Column(db.DateTime, index=False, unique=False, nullable=True)
sent_by = db.Column(db.String, nullable=True)
updated_at = db.Column(db.DateTime, index=False, unique=False, nullable=True)
_status_enum = db.Column('status', NOTIFICATION_STATUS_TYPES_ENUM, index=True, nullable=False, default='created')
_status_enum = db.Column('status', NOTIFICATION_STATUS_TYPES_ENUM, index=True, nullable=True, default='created')
_status_fkey = db.Column(
'notification_status',
db.String,

55
migrations/versions/0106_null_noti_status.py Normal file
View File

@@ -0,0 +1,55 @@
"""
Revision ID: 0106_null_noti_status
Revises: 0105_opg_letter_org
Create Date: 2017-07-10 11:18:27.267721
"""
from alembic import op
from sqlalchemy.dialects import postgresql
revision = '0106_null_noti_status'
down_revision = '0105_opg_letter_org'
def upgrade():
op.alter_column(
'notification_history',
'status',
existing_type=postgresql.ENUM(
'created', 'sending', 'delivered', 'pending', 'failed', 'technical-failure',
'temporary-failure', 'permanent-failure', 'sent', name='notify_status_type'
),
nullable=True
)
op.alter_column(
'notifications',
'status',
existing_type=postgresql.ENUM(
'created', 'sending', 'delivered', 'pending', 'failed', 'technical-failure',
'temporary-failure', 'permanent-failure', 'sent', name='notify_status_type'
),
nullable=True
)
def downgrade():
op.alter_column(
'notifications',
'status',
existing_type=postgresql.ENUM(
'created', 'sending', 'delivered', 'pending', 'failed', 'technical-failure',
'temporary-failure', 'permanent-failure', 'sent', name='notify_status_type'
),
nullable=False
)
op.alter_column(
'notification_history',
'status',
existing_type=postgresql.ENUM(
'created', 'sending', 'delivered', 'pending', 'failed', 'technical-failure',
'temporary-failure', 'permanent-failure', 'sent', name='notify_status_type'
),
nullable=False
)